Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VPC related issues and minor lint updates #622

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Fix VPC related issues and minor lint updates #622

merged 2 commits into from
Apr 8, 2022

Conversation

Prajyot-Parab
Copy link
Contributor

What this PR does / why we need it:

  • Fix VPC related issues
    • Fix service endpoint url
    • Add proper resource group ID to function calls
  • Minor post-liniting process updates

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #615

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Fix VPC related issues and minor lint updates.

@k8s-ci-robot k8s-ci-robot added the area/provider/ibmcloud Issues or PRs related to ibmcloud provider label Apr 8, 2022
@netlify
Copy link

netlify bot commented Apr 8, 2022 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 6ba1148
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/624fe7a27d573f000916ac88
😎 Deploy Preview https://deploy-preview-622--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 8, 2022
@Prajyot-Parab
Copy link
Contributor Author

/cc @mkumatag

@k8s-ci-robot k8s-ci-robot requested a review from mkumatag April 8, 2022 05:52
mkumatag
mkumatag requested changes Apr 8, 2022
View reviewed changes
config/crd/bases/infrastructure.cluster.x-k8s.io_ibmpowervsclusters.yaml
@@ -18,7 +18,7 @@ spec:
- name: v1alpha4
schema:
openAPIV3Schema:
description: IBMPowerVSCluster is the Schema for the ibmpowervsclusters API
description: IBMPowerVSCluster is the Schema for the ibmpowervsclusters API.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering how it listing didn't fail before?!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes were added as part of make manifests target, so I am assuming we need to add missing verify-manifests target to Makefile.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets create a task for the same.

controllers/ibmvpccluster_controller.go Show resolved Hide resolved
@Prajyot-Parab Prajyot-Parab requested a review from mkumatag April 8, 2022 07:41
mkumatag
mkumatag requested changes Apr 8, 2022
View reviewed changes
docs/book/src/getting-started.md Outdated Show resolved Hide resolved
@Prajyot-Parab
Fix VPC related issues
6ba1148 
Signed-off-by: Prajyot-Parab <[email protected]>
@Prajyot-Parab Prajyot-Parab requested a review from mkumatag April 8, 2022 07:44
mkumatag
mkumatag approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit cc61a06 into kubernetes-sigs:main Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

@jichenjc jichenjc Awaiting requested review from jichenjc

@wentao-zh wentao-zh Awaiting requested review from wentao-zh

Assignees

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VPC: Invalid zone eu-de-{1,2,3} on cluster creation
3 participants
@Prajyot-Parab @k8s-ci-robot @mkumatag