-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add external Power VS cloud provider support #614
Add external Power VS cloud provider support #614
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
templates/cluster-template-powervs-external-cloud-provider.yaml
Outdated
Show resolved
Hide resolved
we also need to explore how to trigger this in the post-submit flow to trigger the image build |
610954b
to
c86301e
Compare
hack/ccm/Makefile
Outdated
VPC_CONTROLLER_COMMIT?="" | ||
POWERVS_CLOUD_CONTROLLER_COMMIT?="" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be good if we document these commits somewhere, can be even in the same makefile too. Whenever we want to bump the version - we can just update the makefile and build the image for the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
8db931d
to
7ac45fb
Compare
6cbfbf2
to
2640bb2
Compare
/hold Hold this PR until, We have PR submitted to test-infra to push the image, Just to make sure no other changes are required here. |
where is the PR in the test-infra? can you please mention the link here? and also we need to have cloudbuild.yaml to build the image in the Google cloud infra. |
Not yet submitted, Will be creating soon and link it here |
test-infra PR: kubernetes/test-infra#25888 |
/hold cancel |
7459dcc
to
c250a7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also fix the ci errors
9736877
to
bb03e0e
Compare
All the review comments are addressed. |
/test all |
/test help |
@mkumatag: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few minor nits
Review comments are addressed and This PR is ready for next review. |
IBMACCOUNT_ID="ibm-accountid" \ | ||
IBMVPC_RESOURCE_GROUP="" \ | ||
IBMVPC_SUBNET_NAMES="" \ | ||
IBMVPC_NAME="" \ | ||
IBMVPC_REGION="" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not here, you can set them default in the template itself.
d08486e
to
8c72d59
Compare
docs/book/src/SUMMARY.md
Outdated
@@ -12,6 +12,7 @@ | |||
- [Power VS Cluster](./topics/powervs/index.md) | |||
- [Prerequisites](./topics/powervs/prerequisites.md) | |||
- [Creating a cluster](./topics/powervs/creating-a-cluster.md) | |||
- [External Cloud Provider](./topics/powervs/external-cloud-provider.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [External Cloud Provider](./topics/powervs/external-cloud-provider.md) | |
- [Creating a cluster with External Cloud Provider](./topics/powervs/external-cloud-provider.md) |
ee0b35d
to
0f14807
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Karthik-K-N, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR contains the changes to include a power vs cluster template with external cloud provider integration
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #449
Special notes for your reviewer:
/area provider/ibmcloud
Release note: