Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external Power VS cloud provider support #614

Merged

Conversation

Karthik-K-N
Copy link
Contributor

What this PR does / why we need it:

This PR contains the changes to include a power vs cluster template with external cloud provider integration

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #449

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels Apr 1, 2022
@netlify
Copy link

netlify bot commented Apr 1, 2022

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 0f14807
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/62552edb6689aa0008ab6bfd
😎 Deploy Preview https://deploy-preview-614--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 1, 2022
hack/ccm/Dockerfile Show resolved Hide resolved
hack/ccm/Dockerfile Show resolved Hide resolved
hack/ccm/Makefile Outdated Show resolved Hide resolved
@mkumatag
Copy link
Member

mkumatag commented Apr 1, 2022

we also need to explore how to trigger this in the post-submit flow to trigger the image build

@Karthik-K-N Karthik-K-N force-pushed the external-cloud-provider branch from 610954b to c86301e Compare April 4, 2022 13:09
Comment on lines 3 to 4
VPC_CONTROLLER_COMMIT?=""
POWERVS_CLOUD_CONTROLLER_COMMIT?=""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be good if we document these commits somewhere, can be even in the same makefile too. Whenever we want to bump the version - we can just update the makefile and build the image for the change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@Karthik-K-N Karthik-K-N force-pushed the external-cloud-provider branch from 8db931d to 7ac45fb Compare April 4, 2022 16:29
hack/ccm/Makefile Outdated Show resolved Hide resolved
hack/ccm/Makefile Outdated Show resolved Hide resolved
@Karthik-K-N Karthik-K-N force-pushed the external-cloud-provider branch from 6cbfbf2 to 2640bb2 Compare April 6, 2022 09:30
@Karthik-K-N Karthik-K-N changed the title [WIP] Add external Power VS cloud provider support Add external Power VS cloud provider support Apr 6, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2022
@Karthik-K-N
Copy link
Contributor Author

/hold

Hold this PR until, We have PR submitted to test-infra to push the image, Just to make sure no other changes are required here.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2022
@mkumatag
Copy link
Member

mkumatag commented Apr 6, 2022

/hold

Hold this PR until, We have PR submitted to test-infra to push the image, Just to make sure no other changes are required here.

where is the PR in the test-infra? can you please mention the link here? and also we need to have cloudbuild.yaml to build the image in the Google cloud infra.

@Karthik-K-N
Copy link
Contributor Author

/hold
Hold this PR until, We have PR submitted to test-infra to push the image, Just to make sure no other changes are required here.

where is the PR in the test-infra? can you please mention the link here? and also we need to have cloudbuild.yaml to build the image in the Google cloud infra.

Not yet submitted, Will be creating soon and link it here

@Karthik-K-N
Copy link
Contributor Author

test-infra PR: kubernetes/test-infra#25888

@Karthik-K-N
Copy link
Contributor Author

/hold cancel
@mkumatag could you please take a look

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2022
@Karthik-K-N Karthik-K-N force-pushed the external-cloud-provider branch from 7459dcc to c250a7b Compare April 7, 2022 05:09
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also fix the ci errors

cloudbuild.yaml Outdated Show resolved Hide resolved
@Karthik-K-N
Copy link
Contributor Author

All the review comments are addressed.

@mkumatag
Copy link
Member

mkumatag commented Apr 9, 2022

/test all

@mkumatag
Copy link
Member

mkumatag commented Apr 9, 2022

/test all

/test help

@k8s-ci-robot
Copy link
Contributor

@mkumatag: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-ibmcloud-build
  • /test pull-cluster-api-provider-ibmcloud-make
  • /test pull-cluster-api-provider-ibmcloud-smoke-test
  • /test pull-cluster-api-provider-ibmcloud-test
  • /test pull-cluster-api-provider-ibmcloud-verify

Use /test all to run all jobs.

In response to this:

/test all

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor nits

@Karthik-K-N
Copy link
Contributor Author

Review comments are addressed and This PR is ready for next review.

Comment on lines 22 to 26
IBMACCOUNT_ID="ibm-accountid" \
IBMVPC_RESOURCE_GROUP="" \
IBMVPC_SUBNET_NAMES="" \
IBMVPC_NAME="" \
IBMVPC_REGION="" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not here, you can set them default in the template itself.

@Karthik-K-N Karthik-K-N force-pushed the external-cloud-provider branch from d08486e to 8c72d59 Compare April 12, 2022 07:20
@@ -12,6 +12,7 @@
- [Power VS Cluster](./topics/powervs/index.md)
- [Prerequisites](./topics/powervs/prerequisites.md)
- [Creating a cluster](./topics/powervs/creating-a-cluster.md)
- [External Cloud Provider](./topics/powervs/external-cloud-provider.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [External Cloud Provider](./topics/powervs/external-cloud-provider.md)
- [Creating a cluster with External Cloud Provider](./topics/powervs/external-cloud-provider.md)

@Karthik-K-N Karthik-K-N force-pushed the external-cloud-provider branch from ee0b35d to 0f14807 Compare April 12, 2022 07:48
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Karthik-K-N, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1dcd1b0 into kubernetes-sigs:main Apr 12, 2022
@Karthik-K-N Karthik-K-N deleted the external-cloud-provider branch April 12, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants