Add Vpc image docs #613

FischerLGLN · 2022-03-31T09:21:41Z

What this PR does / why we need it:
Enrich information how to build and upload a capi vm image to IBM Cloud.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Special notes for your reviewer:

/area provider/ibmcloud

linux-foundation-easycla · 2022-03-31T09:21:45Z

The committers listed above are authorized under a signed CLA.

✅ login: FischerLGLN (bce7083, e0c5f21)

netlify · 2022-03-31T09:21:46Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name	Link
🔨 Latest commit	`905b027`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/625542d1ef8db400082b66cb
😎 Deploy Preview	https://deploy-preview-613--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

k8s-ci-robot · 2022-03-31T09:21:48Z

Welcome @FischerLGLN!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-ibmcloud 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-ibmcloud has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-03-31T09:21:49Z

Hi @FischerLGLN. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mkumatag · 2022-03-31T09:23:30Z

The committers listed above are authorized under a signed CLA.

✅ login: FischerLGLN (bce7083, e0c5f21, 14c6dd7)

mkumatag · 2022-03-31T09:24:25Z

/ok-to-test

mkumatag · 2022-03-31T09:24:38Z

@wentao-zh please review this PR

FischerLGLN · 2022-03-31T09:27:21Z

@mkumatag Regarding Personal or corporate CLA. I think this is a personal CLA, right?

FischerLGLN · 2022-03-31T09:29:33Z

Or is it corporate CLA, because I do it during working hours?

mkumatag · 2022-03-31T09:33:30Z

Or is it corporate CLA, because I do it during working hours?

depends on the organisation you are working in, if they have a corporate CLA signed with CNCF you can be part of that team(company sponsored) or you can choose personal(you need to confirm with your management on this), working hours doesn't really matters ;)

FischerLGLN · 2022-03-31T09:36:45Z

Or is it corporate CLA, because I do it during working hours?

depends on the organisation you are working in, if they have a corporate CLA signed with CNCF you can be part of that team(company sponsored) or you can choose personal(you need to confirm with your management on this), working hours doesn't really matters ;)

Thank you, I signed personal, because we haven't signed something with CNCF and I work in german public sector and this is just a side project :)

mkumatag · 2022-04-07T16:20:20Z

docs/book/src/machine-images/vpc.md

@@ -1 +1,62 @@
-This page is still being written - stay tuned!


This location is present to host the prebuilt images for the users to use, I'm wondering if we can move this page under Developer Guide section and refer in this page instead.

@mkumatag Hi, how about moving my changes from vpc.md to this
https://cluster-api-ibmcloud.sigs.k8s.io/topics/vpc/prerequisites.html
prerequisites part like it is done in

https://cluster-api-ibmcloud.sigs.k8s.io/topics/powervs/prerequisites.html#build-workload-cluster-image

I would do that instead and leave this note in vpc.md

This page is still being written - stay tuned!

I see its already here in the vpc section - https://cluster-api-ibmcloud.sigs.k8s.io/topics/vpc/prerequisites.html#build-workload-cluster-image, I prefer creating a separate page for the building the image itself and refer wherever you want. Whole information into prerequisites section will hard to digest.

@mkumatag I pushed my changes to https://github.com/FischerLGLN/cluster-api-provider-ibmcloud :)
However, I don't see an update in this PR.

Ah, now it is there.

@mkumatag
There is some confusion around markdown and html in this repo.

See here:
https://cluster-api-ibmcloud.sigs.k8s.io/machine-images/vpc.html
https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/main/docs/book/src/machine-images/vpc.md

I made a reference to a uploading-an-image.md (instead of your opened html) inside the prerequisites.md.
Does this cause this error?

@mkumatag According to your screenshot, there should be a 4.1.3 in the left.
Maybe the netlify bot hasn't redeployed my changes.

Okay, I can locally test with.
make serve
Same bad result, have to investigate 🤔

@mkumatag

I had to fetch some files from cluster-api-provider-ibmcloud upstream, now they are added in this pr, but netlify isn't triggered yet.

mkumatag · 2022-04-08T03:38:26Z

/cc @Prajyot-Parab

…md and prerequisites.md

k8s-ci-robot · 2022-04-11T13:12:25Z

@FischerLGLN: The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-ibmcloud-build
/test pull-cluster-api-provider-ibmcloud-make
/test pull-cluster-api-provider-ibmcloud-smoke-test
/test pull-cluster-api-provider-ibmcloud-test
/test pull-cluster-api-provider-ibmcloud-verify

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mkumatag

/lgtm
/approve

k8s-ci-robot · 2022-04-12T09:19:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FischerLGLN, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mkumatag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

FischerLGLN added 2 commits March 31, 2022 11:06

Writing howto build and upload VPC images

bce7083

Fixing links

e0c5f21

k8s-ci-robot added the area/provider/ibmcloud Issues or PRs related to ibmcloud provider label Mar 31, 2022

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 31, 2022

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 31, 2022

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 31, 2022

k8s-ci-robot requested review from gyliu513 and wentao-zh March 31, 2022 09:21

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 31, 2022

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 31, 2022

mkumatag requested changes Apr 7, 2022

View reviewed changes

k8s-ci-robot requested a review from Prajyot-Parab April 8, 2022 03:38

FischerLGLN and others added 2 commits April 11, 2022 13:02

Moved image docs into uploading-an-image.md, put references in index.…

14c6dd7

…md and prerequisites.md

Merge branch 'kubernetes-sigs:main' into vpc-image-docs

1d947fa

Adding link into summary.md

905b027

mkumatag added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 12, 2022

mkumatag approved these changes Apr 12, 2022

View reviewed changes

k8s-ci-robot assigned mkumatag Apr 12, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2022

k8s-ci-robot merged commit 3fdb551 into kubernetes-sigs:main Apr 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Vpc image docs #613

Add Vpc image docs #613

FischerLGLN commented Mar 31, 2022

linux-foundation-easycla bot commented Mar 31, 2022 •

edited

Loading

netlify bot commented Mar 31, 2022 •

edited

Loading

k8s-ci-robot commented Mar 31, 2022

k8s-ci-robot commented Mar 31, 2022

mkumatag commented Mar 31, 2022 •

edited by linux-foundation-easycla bot

Loading

mkumatag commented Mar 31, 2022

mkumatag commented Mar 31, 2022

FischerLGLN commented Mar 31, 2022

FischerLGLN commented Mar 31, 2022

mkumatag commented Mar 31, 2022

FischerLGLN commented Mar 31, 2022

mkumatag Apr 7, 2022

FischerLGLN Apr 11, 2022

mkumatag Apr 11, 2022 •

edited

Loading

FischerLGLN Apr 11, 2022

FischerLGLN Apr 11, 2022

FischerLGLN Apr 11, 2022

FischerLGLN Apr 11, 2022

FischerLGLN Apr 11, 2022

FischerLGLN Apr 11, 2022

FischerLGLN Apr 11, 2022

mkumatag commented Apr 8, 2022

k8s-ci-robot commented Apr 11, 2022

mkumatag left a comment

k8s-ci-robot commented Apr 12, 2022

		@@ -1 +1,62 @@
		This page is still being written - stay tuned!

Add Vpc image docs #613

Add Vpc image docs #613

Conversation

FischerLGLN commented Mar 31, 2022

linux-foundation-easycla bot commented Mar 31, 2022 • edited Loading

netlify bot commented Mar 31, 2022 • edited Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

k8s-ci-robot commented Mar 31, 2022

k8s-ci-robot commented Mar 31, 2022

mkumatag commented Mar 31, 2022 • edited by linux-foundation-easycla bot Loading

mkumatag commented Mar 31, 2022

mkumatag commented Mar 31, 2022

FischerLGLN commented Mar 31, 2022

FischerLGLN commented Mar 31, 2022

mkumatag commented Mar 31, 2022

FischerLGLN commented Mar 31, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mkumatag Apr 11, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mkumatag commented Apr 8, 2022

k8s-ci-robot commented Apr 11, 2022

mkumatag left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Apr 12, 2022

linux-foundation-easycla bot commented Mar 31, 2022 •

edited

Loading

netlify bot commented Mar 31, 2022 •

edited

Loading

mkumatag commented Mar 31, 2022 •

edited by linux-foundation-easycla bot

Loading

mkumatag Apr 11, 2022 •

edited

Loading