Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install kubectl for e2e tests #541

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Install kubectl for e2e tests #541

merged 1 commit into from
Feb 4, 2022

Conversation

Amulyam24
Copy link
Contributor

What this PR does / why we need it:
E2E tests require kubectl as a prerequisite. Install it via existing scripts.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 4, 2022
@netlify
Copy link

netlify bot commented Feb 4, 2022

✔️ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

🔨 Explore the source changes: 99b4b28

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/61fcfe7659fba200077c6c02

😎 Browse the preview: https://deploy-preview-541--kubernetes-sigs-cluster-api-ibmcloud.netlify.app

@k8s-ci-robot
Copy link
Contributor

Hi @Amulyam24. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 4, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 4, 2022
@Amulyam24
Copy link
Contributor Author

@mkumatag , missed this earlier in local testing(as if was already installed) but kubectl is required for applying the cluster template.

INFO: Applying the cluster template yaml to the cluster                                                                           
                                                                                                                                             
[AfterEach] Workload cluster creation                                                                                                        
  /root/go/src/github.com/cluster-api-provider-ibmcloud/test/e2e/e2e_test.go:76                                                              
STEP: Unable to dump workload cluster logs as the cluster is nil                                                                             
STEP: Dumping all the Cluster API resources in the "create-workload-cluster-9uqod5" namespace                                                
STEP: Deleting all clusters in the create-workload-cluster-9uqod5 namespace                                                                  
STEP: Deleting namespace used for hosting the "create-workload-cluster" test spec                                                            
INFO: Deleting namespace create-workload-cluster-9uqod5                                                                                      
                                                                                                                                             
• Failure [0.880 seconds]                                                                                                                    
Workload cluster creation                                                                                                                    
/root/go/src/github.com/cluster-api-provider-ibmcloud/test/e2e/e2e_test.go:41                                                                
  Creating a highly available control-plane cluster                                                                                          
  /root/go/src/github.com/cluster-api-provider-ibmcloud/test/e2e/e2e_test.go:137                                                             
    Should create a cluster with 3 control-plane nodes and 1 worker node [It]                                                                
    /root/go/src/github.com/cluster-api-provider-ibmcloud/test/e2e/e2e_test.go:138                                                           
                                                                                                                                             
    Expected success, but got an error:                                                                                                      
        <*errors.withStack | 0xc000643818>: {                                                                                                
            error: <*exec.Error | 0xc001dbd620>{
                Name: "kubectl",
                Err: <*errors.errorString | 0xc0003373d0>{
                    s: "executable file not found in $PATH",
                },
            },                     
            stack: [0x1546667, 0x1546c7d, 0x16dc84c, 0x1a7ef94, 0x1ad8834, 0x73283a, 0x732205, 0x7318fb, 0x737689, 0x737067, 0x758525, 0x7582
45, 0x757a85, 0x759d32, 0x765ee5, 0x765cfe, 0x1ad715e, 0x515042, 0x46b181],
        }                          
        exec: "kubectl": executable file not found in $PATH

    /root/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/clusterctl/clusterctl_helpers.go:273

@mkumatag
Copy link
Member

mkumatag commented Feb 4, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 4, 2022
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit 595a965 into kubernetes-sigs:main Feb 4, 2022
@Amulyam24 Amulyam24 deleted the add-kubectl branch March 1, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants