-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix network/image webhook validations #523
Conversation
✔️ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready! 🔨 Explore the source changes: 95b586f 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/61f7a23289a5bc0007d9428c 😎 Browse the preview: https://deploy-preview-523--kubernetes-sigs-cluster-api-ibmcloud.netlify.app |
Hi @Prajyot-Parab. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this, I'm wondering if we can have following marker for the API spec to force user to specify the non empty string like:
+kubebuilder:validation:MinLength=1
checking |
bbf2664
to
09cbd00
Compare
/ok-to-test |
09cbd00
to
d82df08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix the test failure as well.
Signed-off-by: Prajyot-Parab <[email protected]>
d82df08
to
95b586f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkumatag, Prajyot-Parab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Prajyot-Parab [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #521
Special notes for your reviewer:
/area provider/ibmcloud
Release note: