-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set subnet CIDR block automatically by getting VPC AddrPrefix #344
Conversation
@emmayang: GitHub didn't allow me to request PR reviews from the following users: wentao-zh. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @emmayang. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few nits, otherwise changes lgtm
cloud/scope/cluster.go
Outdated
return "", fmt.Errorf("Error when getting subnet addr prefix for VPC %s in zone %s", vpcID, zone) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return "", fmt.Errorf("Error when getting subnet addr prefix for VPC %s in zone %s", vpcID, zone) | |
} | |
} | |
return "", fmt.Errorf("not found a valid CIDR for VPC %s in zone %s", vpcID, zone) | |
} | |
} |
cloud/scope/cluster.go
Outdated
options := &vpcv1.ListVPCAddressPrefixesOptions{} | ||
options.VPCID = &vpcID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
options := &vpcv1.ListVPCAddressPrefixesOptions{} | |
options.VPCID = &vpcID | |
options := &vpcv1.ListVPCAddressPrefixesOptions{ | |
VPCID: &vpcID, | |
} |
cloud/scope/cluster.go
Outdated
@@ -195,13 +196,9 @@ func (s *ClusterScope) CreateSubnet() (*vpcv1.Subnet, error) { | |||
|
|||
options := &vpcv1.CreateSubnetOptions{} | |||
var cidrBlock string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line can be deleted and line can be modified as:
cidrBlock, err := s.getSubnetAddrPrefix(s.IBMVPCCluster.Status.VPC.ID, s.IBMVPCCluster.Spec.Zone)
@mkumatag thanks for your review, I've updated the PR. |
thanks, please squash the commits. |
address review comments
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: emmayang, gyliu513 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #319
Specify your PR reviewers:
/cc @gyliu513 @jichenjc @xunpan @wentao-zh
Special notes for your reviewer:
/area provider/ibmcloud
Release note: