✨manager: add liveness/readiness probes

[cpanato]

What this PR does / why we need it:
Add liveness/readiness probes similar did here: kubernetes-sigs/cluster-api#2156 and in other capX

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Specify your PR reviewers:

/cc @gyliu513 @jichenjc @xunpan

Special notes for your reviewer:

/area provider/ibmcloud

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

manager: add liveness/readiness probes

[k8s-ci-robot]

Hi @cpanato. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jichenjc]

/ok-to-test

[jichenjc]

/lgtm

[cpanato]

Humm looks like need to bump controller-runtime will do in another PR

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cpanato
To complete the pull request process, please assign jichenjc
You can assign the PR to them by writing /assign @jichenjc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cpanato]

@gyliu513 looks like my previous PR for bumping the modules #292 bump in the require section 🤦‍♂ and forgot the replace. :(

but for this PR works we need to bump the cluster-api and that have some update changes to v1aplha2

i can try to take a look on that if you find that is useful. thoughts?

[jichenjc]

yes, cluster-api v1alpha2 is a good thing , let us know you need any help
for this as I did some thing for openstack before

[cpanato]

@jichenjc looks like it is a lot of things to do :/ not sure if i will have enough time to do that soon and the knowledge as well

[jichenjc]

yes.. I understand it takes time .. just let me know you want to do it then I can provide links we did before for openstack

[cpanato]

@jichenjc thanks, yep links to the previous work will be great!

[jichenjc]

@cpanato please refer to the discussion and all the items listed kubernetes-sigs/cluster-api-provider-openstack#380, as this ibmcloud implementation refer to openstack when it's first built
the things listed in that issue should be helpful :)

[gyliu513]

/retest

[k8s-ci-robot]

@cpanato: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-cluster-api-provider-ibmcloud-test	302f85d	link	/test pull-cluster-api-provider-ibmcloud-test
pull-cluster-api-provider-ibmcloud-check	302f85d	link	/test pull-cluster-api-provider-ibmcloud-check
pull-cluster-api-provider-ibmcloud-make	302f85d	link	/test pull-cluster-api-provider-ibmcloud-make

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[cpanato]

will close this for now, need upgrade the API here first