Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirect url for meeting document #1986

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

Karthik-K-N
Copy link
Contributor

What this PR does / why we need it:

This would beautify the meeting notes link. Like below

  1. Existing way: https://docs.google.com/document/d/1oWnqXy1VFv0E3kovQoZfS6IlVP0L4eaQsN-2HYC_6_A
  2. New way: https://cluster-api-ibmcloud.sigs.k8s.io/agenda.html

Reference: https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/2125/files

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

None

@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 3, 2024
Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 85cba14
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/66fe3afcbfca460008daf9f0
😎 Deploy Preview https://deploy-preview-1986--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 3, 2024
Copy link
Contributor

@Amulyam24 Amulyam24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Karthik-K-N, how can I view this change? Will it be part of the book?

@mkumatag
Copy link
Member

mkumatag commented Oct 3, 2024

@Karthik-K-N, how can I view this change? Will it be part of the book?

https://deploy-preview-1986--kubernetes-sigs-cluster-api-ibmcloud.netlify.app/agenda.html

@Amulyam24
Copy link
Contributor

@Karthik-K-N, how can I view this change? Will it be part of the book?

https://deploy-preview-1986--kubernetes-sigs-cluster-api-ibmcloud.netlify.app/agenda.html

Thanks @mkumatag!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2024
Copy link
Contributor

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Karthik-K-N, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3e538a5 into kubernetes-sigs:main Oct 3, 2024
13 checks passed
@Karthik-K-N
Copy link
Contributor Author

I think currently https://cluster-api-ibmcloud.sigs.k8s.io/ is pointing to release-0.7 branch is this correct?
If so can I cherry-pick this PR to 0.8 and 0.7 respectively so https://cluster-api-ibmcloud.sigs.k8s.io/agenda.html works?

Because https://main.cluster-api-ibmcloud.sigs.k8s.io/agenda.html is working as expected.

@Amulyam24
Copy link
Contributor

I think currently https://cluster-api-ibmcloud.sigs.k8s.io/ is pointing to release-0.7 branch is this correct?

It will be pointing to release-0.8 branch

If so can I cherry-pick this PR to 0.8 and 0.7 respectively so https://cluster-api-ibmcloud.sigs.k8s.io/agenda.html works?

Because https://main.cluster-api-ibmcloud.sigs.k8s.io/agenda.html is working as expected.

yes

@Karthik-K-N
Copy link
Contributor Author

/cherrypick release-0.8

@Karthik-K-N
Copy link
Contributor Author

/cherrypick release-0.7

@k8s-infra-cherrypick-robot

@Karthik-K-N: new pull request created: #1987

In response to this:

/cherrypick release-0.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@Karthik-K-N: new pull request created: #1988

In response to this:

/cherrypick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants