-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for JSON output format for logs #1974
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
3831985
to
21aa771
Compare
@Karthik-K-N can you please update the description with the details like what additional flags it will add and how users can use them and also sample logs post applying this option? |
21aa771
to
64323e9
Compare
64323e9
to
f43fbfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Karthik-K-N, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Most of the core components of cluster-api supports JSON output format for logs and capi is planning to make json output format for logs as default in future releases rather than having text output format like now.
This PR adds support for the same in cluster-api-provider-ibmcloud repository, This will help in easy parsing of logs in obervability tools.
User needs to pass additional flag
--logging-format=json
to set the output log format to JSONDefault text format log output
Log format when JSON output format is set
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/area provider/ibmcloud
Release note: