VPC: Add v2 support for VPC reconcile #1886
Conversation
k8s-ci-robot
added
the
area/provider/ibmcloud
k8s-ci-robot
added
cncf-cla: yes
|
Hi @cjschaef. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/XL
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
cjschaef
force-pushed
the
vpc_reconcile_vpc
branch
from
b93351b to
d766713
Compare
cloud/scope/vpc_cluster.go
Outdated
| } | ||
|
|
||
| // Collect the Network's Resource Group Id if it is defined in Spec. | ||
| if s.NetworkSpec() != nil && s.NetworkSpec().ResourceGroup != nil { |
There was a problem hiding this comment.
May be negating the if and early return would help in better formating and understanding something like.
if s.NetworkSpec() == nil || s.NetworkSpec().ResourceGroup == nil {
// Otherwise, default to using the cluster's Resource Group ID.
return s.GetResourceGroupID()
}
There was a problem hiding this comment.
Sure, I can change this.
cloud/scope/vpc_cluster.go
Outdated
| s.SetResourceStatus(infrav1beta2.ResourceTypeVPC, &infrav1beta2.ResourceStatus{ | ||
| ID: *vpcDetails.ID, | ||
| Name: s.NetworkSpec().VPC.Name, | ||
| Ready: false, |
There was a problem hiding this comment.
Any reasons for setting Ready to false here?
There was a problem hiding this comment.
In this code path, since we performed the VPC lookup by VPC API call, it is probably okay to mark Ready as true, hoping we don't hit a timing related issue via this code path.
| s.SetResourceStatus(infrav1beta2.ResourceTypeVPC, &infrav1beta2.ResourceStatus{ | ||
| ID: *vpcDetails.ID, | ||
| Name: vpcName, | ||
| Ready: false, |
There was a problem hiding this comment.
I think IIUC in the next iteration you are expecting Ready to be set to true based on Status.
There was a problem hiding this comment.
That is my expectation, to update the status to Ready on the next round of reconcile (to make sure it is actually found via VPC API (GetVPC) call.
|
@cjschaef for my better understaind , whats the format for tag you have decided to use on VPC resources. |
Add support to the v2 path to reconcile a VPC. Includes adding GlobalTagging support, and extending ResourceManager support.
cjschaef
force-pushed
the
vpc_reconcile_vpc
branch
from
d766713 to
a3e6268
Compare
|
For now, I expect to tag all created resources with the |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjschaef, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Add support to the v2 path to reconcile a VPC.
Includes adding GlobalTagging support, and extending ResourceManager support.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/area provider/ibmcloud
Release note: