VPC: Extend VPC related API's for v2 VPC reconcile #1883

cjschaef · 2024-07-15T23:42:47Z

Extend the API's used in the v2 support of reconciling VPC for the VPCCluster support.

What this PR does / why we need it: implements the v2 support of reconciling a VPC for VPCCluster support

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

implement new VPC reconcile for VPCClusters

k8s-ci-robot · 2024-07-15T23:42:56Z

Hi @cjschaef. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

netlify · 2024-07-15T23:43:03Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name	Link
🔨 Latest commit	`4909b40`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/6697e34744bb760008574f2f
😎 Deploy Preview	https://deploy-preview-1883--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Karthik-K-N · 2024-07-16T04:45:31Z

/ok-to-test

mkumatag · 2024-07-16T05:16:52Z

api/v1beta2/types.go

@@ -400,3 +400,53 @@ type VPCEndpoint struct {
 	// +optional
 	LBID *string `json:"loadBalancerIPID,omitempty"`
 }
+
+// GenericResourceReference represents a generic IBM Cloud resource.
+type GenericResourceReference struct {


I don't see this is used anywhere!

Sorry, too early for that resource, I'll remove it for this PR.

mkumatag · 2024-07-16T05:31:39Z

api/v1beta2/ibmvpccluster_types.go

+}
+
+// VPCResourceStatus identifies a VPC resource by id (and name) and whether it is ready.
+type VPCResourceStatus struct {


ResourceStatus also look the same, can we reuse?

I had designed the two status' initially, but can not recall why I had a unique one for VPC resources ATM.
I'll remove and use ResourceStatus for all resources instead.

Removed to use ResourceStatus

Karthik-K-N

I think its also ok to have one big PR with various small commits, so it gives overall good picture of intent of changes.

Karthik-K-N · 2024-07-17T05:33:48Z

api/v1beta2/ibmvpccluster_types.go

@@ -113,7 +113,11 @@ type VPCNetworkSpec struct {
 	// +optional
 	ResourceGroup *string `json:"resourceGroup,omitempty"`

-	// TODO(cjschaef): Complete spec definition (SecurityGroups, VPC)
+	// vpc defines the IBM Cloud VPC.
+	// +optional


We already have a field named VPC under IBMVPCClusterSpec, so may be lets add a comment whereever it looks appropriate on whats the difference or when to use which field.

I added a little more detail to this field and some other fields/structs, as they related to the extended VPC Infra support.

cjschaef · 2024-07-17T15:28:52Z

Repushing to get CLA to pass.

Done

Extend the API's used in the v2 support of reconciling VPC for the VPCCluster support.

mkumatag

/lgtm

k8s-ci-robot · 2024-07-18T14:58:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjschaef, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mkumatag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 15, 2024

k8s-ci-robot requested review from Amulyam24 and Prajyot-Parab July 15, 2024 23:42

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 15, 2024

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 15, 2024

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 16, 2024

mkumatag requested changes Jul 16, 2024

View reviewed changes

cjschaef force-pushed the vpc_reconcile_vpc_apis branch from 09a4350 to 0de029c Compare July 16, 2024 15:14

Karthik-K-N reviewed Jul 17, 2024

View reviewed changes

cjschaef force-pushed the vpc_reconcile_vpc_apis branch from 0de029c to 81951c8 Compare July 17, 2024 14:34

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 17, 2024

VPC: Extend VPC related API's for v2 VPC reconcile

4909b40

Extend the API's used in the v2 support of reconciling VPC for the VPCCluster support.

cjschaef force-pushed the vpc_reconcile_vpc_apis branch from 81951c8 to 4909b40 Compare July 17, 2024 15:29

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 17, 2024

mkumatag approved these changes Jul 18, 2024

View reviewed changes

k8s-ci-robot assigned mkumatag Jul 18, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2024

k8s-ci-robot merged commit 63be00c into kubernetes-sigs:main Jul 18, 2024
13 checks passed

cjschaef deleted the vpc_reconcile_vpc_apis branch July 18, 2024 15:23

cjschaef mentioned this pull request Aug 7, 2024

Extend VPC (x86_64) Infrastructure reconciliation support #1896

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VPC: Extend VPC related API's for v2 VPC reconcile #1883

VPC: Extend VPC related API's for v2 VPC reconcile #1883

cjschaef commented Jul 15, 2024

k8s-ci-robot commented Jul 15, 2024

netlify bot commented Jul 15, 2024 •

edited

Loading

Karthik-K-N commented Jul 16, 2024

mkumatag Jul 16, 2024

cjschaef Jul 16, 2024

cjschaef Jul 16, 2024

mkumatag Jul 16, 2024

cjschaef Jul 16, 2024

cjschaef Jul 16, 2024

Karthik-K-N left a comment

Karthik-K-N Jul 17, 2024

cjschaef Jul 17, 2024

cjschaef commented Jul 17, 2024 •

edited

Loading

mkumatag left a comment

k8s-ci-robot commented Jul 18, 2024

VPC: Extend VPC related API's for v2 VPC reconcile #1883

VPC: Extend VPC related API's for v2 VPC reconcile #1883

Conversation

cjschaef commented Jul 15, 2024

k8s-ci-robot commented Jul 15, 2024

netlify bot commented Jul 15, 2024 • edited Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Karthik-K-N commented Jul 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Karthik-K-N left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cjschaef commented Jul 17, 2024 • edited Loading

mkumatag left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 18, 2024

netlify bot commented Jul 15, 2024 •

edited

Loading

cjschaef commented Jul 17, 2024 •

edited

Loading