-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor PowerVSClusterscope function to faciliate UT integration #1827
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/hold testing pending. |
@mkumatag @Amulyam24 @dharaneeshvrd Please take a look at the approach and let me know your opinion. If you think of any better approach dont forget to comment here. |
392bbf0
to
2e2c4b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Karthik-K-N, overall LGTM!
I have verified the workflow with cluster creation and able to see cluster getting created successfully.
|
@dharaneeshvrd @mkumatag Please review this PR when you get some time, This will unblock in adding unit test cases. |
Changes looks good to me as well! |
/hold cancel |
2e2c4b0
to
39e0edd
Compare
39e0edd
to
5912bf5
Compare
5912bf5
to
e8a3e48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Karthik-K-N, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/area provider/ibmcloud
Release note: