Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor IsPowerVSZoneSupportsPER() code to use interface #1775

Merged
merged 3 commits into from
May 20, 2024
Merged

Refactor IsPowerVSZoneSupportsPER() code to use interface #1775

merged 3 commits into from
May 20, 2024

Conversation

Shilpa-Gokul
Copy link
Contributor

What this PR does / why we need it:
Currently IsPowerVSZoneSupportsPER() uses a get call directly to fetch datacenter information, this might be a problem to mock when we have to add unit tests, hence refactoring the code to use interface.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1774

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 15, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 15, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Shilpa-Gokul. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@netlify Netlify
Copy link

netlify bot commented May 15, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit e7000af
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/66473a9190bd0a0008ca7a66
😎 Deploy Preview https://deploy-preview-1775--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 15, 2024
@Amulyam24
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 16, 2024
Karthik-K-N
Karthik-K-N reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Overall LGTM, Lets fix the failing test.

pkg/cloud/services/powervs/service.go Outdated Show resolved Hide resolved
@Shilpa-Gokul Shilpa-Gokul requested a review from Karthik-K-N May 16, 2024 09:36
Amulyam24
Amulyam24 reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@Amulyam24 Amulyam24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2024
Karthik-K-N
Karthik-K-N reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

mkumatag
mkumatag requested changes May 17, 2024
View reviewed changes
pkg/cloud/services/powervs/service.go Outdated
@@ -185,3 +187,17 @@ func (s *Service) GetNetworkByName(networkName string) (*models.NetworkReference

return network, nil
}

// GetDatacenters fetches the datacenter capabilities for the given zone.
func (s *Service) GetDatacenters(zone string) (*models.Datacenter, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the below findings you can rename to

Suggested change
func (s *Service) GetDatacenters(zone string) (*models.Datacenter, error) {
func (s *Service) GetDatacenterCapabilities(zone string) (*models.Datacenter, error) {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

param says zone but in the code you are setting the region variable, so what's the expected value here in this zone variable? is it lon or lon04 format?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be zone, Found this conversation which mention to use zone openshift/installer#7736 (comment)

pkg/cloud/services/powervs/service.go Outdated Show resolved Hide resolved
@mkumatag mkumatag added this to the v0.8 milestone May 17, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2024
@mkumatag mkumatag added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 20, 2024
mkumatag
mkumatag approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, Shilpa-Gokul

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 531fd52 into kubernetes-sigs:main May 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karthik-K-N Karthik-K-N Karthik-K-N left review comments

@Amulyam24 Amulyam24 Amulyam24 left review comments

@mkumatag mkumatag mkumatag approved these changes

Assignees

@mkumatag mkumatag

@Amulyam24 Amulyam24

@Karthik-K-N Karthik-K-N

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.

Refactor IsPowerVSZoneSupportsPER() to use interface
5 participants
@Shilpa-Gokul @k8s-ci-robot @Amulyam24 @mkumatag @Karthik-K-N