Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace service with worskpace after power-iaas plugin update #1596

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Replace service with worskpace after power-iaas plugin update #1596

merged 1 commit into from
Jan 31, 2024

Conversation

Amulyam24
Copy link
Contributor

@Amulyam24 Amulyam24 commented Jan 31, 2024

What this PR does / why we need it:
With the power-iaas plugin version update to 1.0.0, replace service-instance references with workspace. This PR fixes the below error.

Plug-in 'power-iaas 1.0.0' was successfully installed into /root/.bluemix/plugins/power-iaas. Use 'ibmcloud plugin show power-iaas' to show its details.
++ jq -r '.[].crn'
++ ibmcloud resource service-instance e7207381-53be-4a6a-b2c1-127580e97466 --output json
+ CRN=crn:v1:bluemix:public:power-iaas:syd04:a/7cfbd5381a434af7a09289e795840d4e:e7207381-53be-4a6a-b2c1-127580e97466::
+ ibmcloud pi service-target crn:v1:bluemix:public:power-iaas:syd04:a/7cfbd5381a434af7a09289e795840d4e:e7207381-53be-4a6a-b2c1-127580e97466::
Error: unknown command "service-target" for "pi"
Run 'pi --help' for usage.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Replace service with worskpace after power-iaas plugin update

@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 31, 2024
Copy link

netlify bot commented Jan 31, 2024

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 2dfa5a3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/65b9dceca631910008f2035b
😎 Deploy Preview https://deploy-preview-1596--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 31, 2024
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2024
@Amulyam24 Amulyam24 changed the title Replace service-target with worskpace after power-iaas plugin update Replace service with worskpace after power-iaas plugin update Jan 31, 2024
@k8s-ci-robot k8s-ci-robot merged commit ba09aa0 into kubernetes-sigs:main Jan 31, 2024
13 checks passed
@Amulyam24 Amulyam24 deleted the e2e-fix branch January 31, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants