Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline documentation for CAPIBM #1508

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Streamline documentation for CAPIBM #1508

merged 1 commit into from
Nov 28, 2023

Conversation

kishen-v
Copy link
Contributor

@kishen-v kishen-v commented Nov 21, 2023 •
edited
Loading

What this PR does / why we need it:
This PR removes redundant documentation.

Which issue(s) this PR fixes:
Fixes #1507, #1511

Special notes for your reviewer: This PR can be co-authored to have more changes addressing other documentation issues. Please feel free to /hold if needed.

kind/documentation

Release note:

NONE

@k8s-ci-robot
Copy link
Contributor

@kishen-v: The label(s) area/kind/documentation cannot be applied, because the repository doesn't have them.

In response to this:

What this PR does / why we need it:
This PR removes redundant documentation.

Which issue(s) this PR fixes:
Fixes #1507

Special notes for your reviewer: This PR can be co-authored to have more changes addressing other documentation issues. Please feel free to /hold if needed.

/area kind/documentation

Release note:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 21, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 21, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit dd84fbf
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/65656df392e95b00081c36a7
😎 Deploy Preview https://deploy-preview-1508--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 21, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @kishen-v. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 21, 2023
mkumatag
mkumatag requested changes Nov 21, 2023
View reviewed changes
docs/book/src/developer/tilt.md Outdated Show resolved Hide resolved
docs/book/src/developer/tilt.md Outdated Show resolved Hide resolved
@mkumatag
Copy link
Member

/cc @Prajyot-Parab @Karthik-K-N
please review

@mkumatag
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 23, 2023
@kishen-v kishen-v force-pushed the docs-cleanup branch 3 times, most recently from 3365445 to ea0d3ac Compare November 27, 2023 09:59
@kishen-v
Copy link
Contributor Author

/cc @Amulyam24.

@kishen-v kishen-v mentioned this pull request Nov 28, 2023
Closed
@mkumatag
Copy link
Member

@Amulyam24 @Karthik-K-N @Prajyot-Parab please review it and give an ack when its ready

@Karthik-K-N
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2023
mkumatag
mkumatag approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2023
@mkumatag
Copy link
Member

/hold

feel free to remove once other folks are comfortable

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2023
Prajyot-Parab
Prajyot-Parab approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Amulyam24
Amulyam24 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@Amulyam24 Amulyam24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, Karthik-K-N, kishen-v, mkumatag, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 28a1012 into kubernetes-sigs:main Nov 28, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prajyot-Parab Prajyot-Parab Prajyot-Parab approved these changes

@Karthik-K-N Karthik-K-N Karthik-K-N approved these changes

@Amulyam24 Amulyam24 Amulyam24 approved these changes

@mkumatag mkumatag mkumatag approved these changes

Assignees

@mkumatag mkumatag

@Amulyam24 Amulyam24

@Karthik-K-N Karthik-K-N

@Prajyot-Parab Prajyot-Parab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge podman titl doc into the tilt development doc
6 participants
@kishen-v @k8s-ci-robot @mkumatag @Karthik-K-N @Amulyam24 @Prajyot-Parab