Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for VPC clusterclass #1500

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Add support for VPC clusterclass #1500

merged 3 commits into from
Nov 20, 2023

Conversation

kishen-v
Copy link
Contributor

What this PR does / why we need it:
This PR enables the support to create Kubernetes clusters on IBM Cloud - VPC Infrastructure using ClusterClass through IBMVPCClusterTemplate

Which issue(s) this PR fixes
Fixes - #974

/area provider/ibmcloud

Release note:

Support creation of clusters on IBM Cloud - VPC infrastructure using ClusterClass

Functionality:

[root@cluster-api1 cluster-api-provider-ibmcloud]# kubectl get ibmvpcclustertemplates
NAME                           AGE
kishen-test-cluster-template   17m
Pasted Graphic 3 Pasted Graphic 5 Pasted Graphic 2 Pasted Graphic 6

@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 17, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 17, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit be94478
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/655996adf8d5f000080c9ab5
😎 Deploy Preview https://deploy-preview-1500--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot
Copy link
Contributor

Hi @kishen-v. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 17, 2023
@kishen-v
Copy link
Contributor Author

cc: @Karthik-K-N.
Thanks for the help! 😄

@kishen-v kishen-v mentioned this pull request Nov 17, 2023
Closed
@Karthik-K-N
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 17, 2023
@mkumatag
Copy link
Member

/cc @Karthik-K-N

@Karthik-K-N
Copy link
Contributor

Need to add documentation similar to https://cluster-api-ibmcloud.sigs.k8s.io/topics/powervs/clusterclass-cluster

Prajyot-Parab
Prajyot-Parab suggested changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kishen-v Include the missing dir under templates specifically for vpc-clusterclass(similar to what we have for powervs), it contains files that are reused as part of overall template and helps in generating them on the fly.

ref - a402887

@Prajyot-Parab
Copy link
Contributor

/cc @Amulyam24

@kishen-v kishen-v force-pushed the clusterclass-vpc branch 2 times, most recently from 96e2bb2 to 9ca8565 Compare November 17, 2023 15:05
@Karthik-K-N
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2023
mkumatag
mkumatag approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishen-v, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9589dad into kubernetes-sigs:main Nov 20, 2023
13 checks passed
@kishen-v kishen-v deleted the clusterclass-vpc branch November 21, 2023 10:09
@Amulyam24 Amulyam24 mentioned this pull request Nov 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karthik-K-N Karthik-K-N Karthik-K-N left review comments

@Amulyam24 Amulyam24 Amulyam24 left review comments

@Prajyot-Parab Prajyot-Parab Prajyot-Parab requested changes

@mkumatag mkumatag mkumatag approved these changes

@gyliu513 gyliu513 Awaiting requested review from gyliu513

Assignees

@mkumatag mkumatag

@Karthik-K-N Karthik-K-N

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kishen-v @k8s-ci-robot @Karthik-K-N @mkumatag @Prajyot-Parab @Amulyam24