-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-0.5] add targets for verifying code and images for vulnerabilities #1487
[release-0.5] add targets for verifying code and images for vulnerabilities #1487
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/cc @mkumatag |
e7f0f4e
to
7e4cd47
Compare
gotest.tools/gotestsum v1.10.0 | ||
k8s.io/code-generator v0.26.10 | ||
k8s.io/code-generator v0.27.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but we have v0.26.10
version used go.mod file in the root dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this, will fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added it to replace section (pin to v0.26.10)
sigs.k8s.io/cluster-api/hack/tools v0.0.0-20231026175444-4ad3af14b736 | ||
sigs.k8s.io/controller-runtime/tools/setup-envtest v0.0.0-20211110210527-619e6b92dab9 | ||
sigs.k8s.io/controller-tools v0.11.4 | ||
sigs.k8s.io/kustomize/kustomize/v4 v4.5.7 | ||
sigs.k8s.io/kustomize/kustomize/v5 v5.0.4-0.20230601165947-6ce0bf390ce3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and also a major version change here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for some reason v4.5.x
kustomize build is failing causing smoke-test check failure, hence had bumped to v5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build of kustomize failing with latest v4, v5 seems to be working fine.
Signed-off-by: Prajyot-Parab <[email protected]>
7e4cd47
to
a3e87c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkumatag, Prajyot-Parab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
filepath
package vulnerabilities.kustomize
to v5Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1484
Special notes for your reviewer:
/area provider/ibmcloud
Release note: