Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cluster-api to v1.6.0-beta.1 #1470

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Update cluster-api to v1.6.0-beta.1 #1470

merged 1 commit into from
Nov 3, 2023

Conversation

Amulyam24
Copy link
Contributor

@Amulyam24 Amulyam24 commented Nov 1, 2023

What this PR does / why we need it:
This PR updates

  • cluster-api to v1.6.0-beta.1
  • k8s to 1.28
  • Involves minor changes to the controller where flag --metrics-bind-addr is deprecated and new flags --diagnostics-address, --insecure-diagnostics are introduced to allow serving metrics, the pprof endpoint and an endpoint to dynamically change log levels securely in production.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1464

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Update cluster-api to v1.6.0-beta.1

@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 1, 2023
@k8s-ci-robot k8s-ci-robot requested a review from jichenjc November 1, 2023 14:16
Copy link

netlify bot commented Nov 1, 2023

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 1c299e9
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/654363fa649e54000828e7ac
😎 Deploy Preview https://deploy-preview-1470--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot requested a review from mkumatag November 1, 2023 14:16
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 1, 2023
main.go Show resolved Hide resolved
@Amulyam24 Amulyam24 changed the title Update cluster-api to v1.6.0-beta.0 Update cluster-api to v1.6.0-beta.1 Nov 2, 2023
main.go Show resolved Hide resolved
main.go Show resolved Hide resolved
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 19c99d6 into kubernetes-sigs:main Nov 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAPI v1.6.0-beta.0 has been released and is ready for testing
3 participants