Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the getting started guide #1324

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Refactor the getting started guide #1324

merged 1 commit into from
Aug 2, 2023

Conversation

Amulyam24
Copy link
Contributor

@Amulyam24 Amulyam24 commented Aug 1, 2023

What this PR does / why we need it:
This PR refactors the doc with a better structure.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1152

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Refactor the getting started guide

@k8s-ci-robot k8s-ci-robot added the area/provider/ibmcloud Issues or PRs related to ibmcloud provider label Aug 1, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 1, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Amulyam24 / name: Amulya Meka (b7ecc76)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 1, 2023
@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit b7ecc76
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/64c8f502a4d61f000832bb17
😎 Deploy Preview https://deploy-preview-1324--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 1, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 1, 2023
@Amulyam24
Copy link
Contributor Author

/cc @Karthik-K-N

Copy link
Contributor

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2023
@Karthik-K-N
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, mkumatag, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6983a47 into kubernetes-sigs:main Aug 2, 2023
@Prajyot-Parab
Copy link
Contributor

/cherrypick release-0.5

@k8s-infra-cherrypick-robot

@Prajyot-Parab: new pull request created: #1326

In response to this:

/cherrypick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Prajyot-Parab
Copy link
Contributor

/cherrypick release-0.4

@k8s-infra-cherrypick-robot

@Prajyot-Parab: #1324 failed to apply on top of branch "release-0.4":

Applying: Refactor the getting started guide
.git/rebase-apply/patch:40: trailing whitespace.
    
.git/rebase-apply/patch:42: trailing whitespace.
     
.git/rebase-apply/patch:44: trailing whitespace.
   
.git/rebase-apply/patch:73: trailing whitespace.
6. Once the management cluster is ready with the required providers up and running, proceed to provisioning the workload cluster. Check the respective sections for [VPC](/topics/vpc/creating-a-cluster.html) and [PowerVS](/topics/powervs/creating-a-cluster.html) to deploy the cluster. 
.git/rebase-apply/patch:102: trailing whitespace.
      
warning: 5 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	docs/book/src/getting-started.md
Falling back to patching base and 3-way merge...
Auto-merging docs/book/src/getting-started.md
CONFLICT (content): Merge conflict in docs/book/src/getting-started.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Refactor the getting started guide
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-0.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Prajyot-Parab pushed a commit to Prajyot-Parab/cluster-api-provider-ibmcloud that referenced this pull request Aug 2, 2023
k8s-ci-robot pushed a commit that referenced this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance the doc
6 participants