Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump github.com/golangci/golangci-lint from 1.50.1 to 1.52.1 #1164

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Bump github.com/golangci/golangci-lint from 1.50.1 to 1.52.1 #1164

merged 1 commit into from
Mar 22, 2023

Conversation

Prajyot-Parab
Copy link
Contributor

@Prajyot-Parab Prajyot-Parab commented Mar 21, 2023 •
edited
Loading

What this PR does / why we need it:

  • Bump github.com/golangci/golangci-lint from 1.50.1 to 1.52.1
  • Fix linting related issues
  • Rename the build tag to capibmtools because when running with tools build tags there's an issue with another package:
go build -tags=tools -o bin/golangci-lint github.com/golangci/golangci-lint/cmd/golangci-lint
../../../../go/pkg/mod/github.com/ryancurrah/[email protected]/tools.go:5:8: import "github.com/t-yuki/gocover-cobertura" is a program, not an importable package
make[1]: *** [bin/golangci-lint] Error 1
make: *** [hack/tools/bin/golangci-lint] Error 2

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Bump github.com/golangci/golangci-lint from 1.50.1 to 1.52.1

@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 21, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 21, 2023
@netlify
Copy link

netlify bot commented Mar 21, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit e64981d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/641adcc6a43d5400080c3c15
😎 Deploy Preview https://deploy-preview-1164--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Prajyot-Parab Prajyot-Parab mentioned this pull request Mar 21, 2023
Closed
@Prajyot-Parab
Copy link
Contributor Author

/cc @Amulyam24 @mkumatag

Amulyam24
Amulyam24 approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@Amulyam24 Amulyam24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2023
mkumatag
mkumatag requested changes Mar 21, 2023
View reviewed changes
cmd/capibmadm/utils/utils.go Outdated Show resolved Hide resolved
api/v1beta1/ibmvpc_conversion.go
@@ -196,7 +196,7 @@ func Convert_v1beta2_IBMVPCMachineSpec_To_v1beta1_IBMVPCMachineSpec(in *infrav1b
return autoConvert_v1beta2_IBMVPCMachineSpec_To_v1beta1_IBMVPCMachineSpec(in, out, s)
}

func Convert_Slice_Pointer_string_To_Slice_Pointer_v1beta2_IBMVPCResourceReference(in *[]*string, out *[]*infrav1beta2.IBMVPCResourceReference, s apiconversion.Scope) error {
func Convert_Slice_Pointer_string_To_Slice_Pointer_v1beta2_IBMVPCResourceReference(in *[]*string, out *[]*infrav1beta2.IBMVPCResourceReference, _ apiconversion.Scope) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly autogenerated code, wondering if there is any action been taken to fix the code in the generator itself?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and also wherever we are removing old var.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any changes in the generator itself, the older version of lint is not detecting this discrepancies but the new one does. Renaming them as the actual function implementation contain those var even though we are not using them as of now wherever they are being referred.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create an issue in the generator repository so that at least they should know what's happening!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a issue in generator (will update), the issues are being picked by newer lint versions only. I think this may have something to do with fixes in latest lint version itself. Meanwhile I guess we are good to merge this one for now.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2023
@Prajyot-Parab Prajyot-Parab changed the title Bump github.com/golangci/golangci-lint from 1.50.1 to 1.52.0 Bump github.com/golangci/golangci-lint from 1.50.1 to 1.52.1 Mar 22, 2023
mkumatag
mkumatag approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, mkumatag, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9b67037 into kubernetes-sigs:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amulyam24 Amulyam24 Amulyam24 approved these changes

@mkumatag mkumatag mkumatag approved these changes

@jichenjc jichenjc Awaiting requested review from jichenjc

@wentao-zh wentao-zh Awaiting requested review from wentao-zh

Assignees

@mkumatag mkumatag

@Amulyam24 Amulyam24

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Prajyot-Parab @k8s-ci-robot @mkumatag @Amulyam24