Add support for powervs image list command #1127

KeerthanaAP · 2023-03-01T16:12:56Z

What this PR does / why we need it:

In this PR, a CLI command to list image is added

 % ./capibmadm powervs image list --service-instance-id 5e1d357c-7603-42a9-b4c1-fe3772bdfa0c --zone lon04
Listing PowerVS images service-instance-id="5e1d357c-7603-42a9-b4c1-fe3772bdfa0c"
ID                                     NAME               STATE    DESCRIPTION   STORAGE POOL    STORAGE TYPE   CREATION DATE              LAST UPDATE DATE           ARCH    CONTAINER FORMAT   DISK FORMAT   ENDIANNESS      HYPERVISOR TYPE    OS     IMAGE TYPE
06ff0390-22e1-41fe-9324-3d637bcdb6f1   CentOS-Stream-8    active                 Tier3-Flash-1   tier3          2023-02-16T15:00:00.000Z   2023-02-16T15:01:31.000Z   ppc64   bare               raw           little-endian   phyp               rhel   stock
47f2f988-d2ea-4cb6-922a-c895bf45f5f4   Linux-CentOS-8-3   active                 Tier3-Flash-1   tier3          2023-02-16T14:57:05.000Z   2023-02-16T14:58:54.000Z   ppc64   bare               raw           little-endian   phyp               rhel   stock

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

netlify · 2023-03-01T16:13:01Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name	Link
🔨 Latest commit	`bcdf937`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/640074754c88d0000883ed5e
😎 Deploy Preview	https://deploy-preview-1127--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

k8s-ci-robot · 2023-03-01T16:13:05Z

Welcome @KeerthanaAP!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-ibmcloud 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-ibmcloud has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-03-01T16:13:06Z

Hi @KeerthanaAP. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

linux-foundation-easycla · 2023-03-01T16:13:17Z

The committers listed above are authorized under a signed CLA.

✅ login: KeerthanaAP / name: Keerthana Arumugam (9ba898d)

Amulyam24 · 2023-03-02T05:15:23Z

/ok-to-test

cmd/capibmadm/cmd/powervs/image/type.go

cmd/capibmadm/cmd/powervs/image/list.go

Amulyam24 · 2023-03-02T11:34:55Z

cmd/capibmadm/cmd/powervs/image/list.go

+	}
+
+	printerObj, err := printer.New(options.GlobalOptions.Output, os.Stdout)
+


extra line can be omitted here.

Amulyam24

Apart from minor comment, LGTM!

mkumatag

/lgtm

k8s-ci-robot · 2023-03-02T12:21:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KeerthanaAP, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mkumatag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the area/provider/ibmcloud Issues or PRs related to ibmcloud provider label Mar 1, 2023

k8s-ci-robot requested review from mkumatag and relyt0925 March 1, 2023 16:13

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 1, 2023

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 1, 2023

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 1, 2023

KeerthanaAP force-pushed the capibmadm-powervs-image-list branch from 9ba898d to 2526706 Compare March 2, 2023 05:01

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 2, 2023

Amulyam24 reviewed Mar 2, 2023

View reviewed changes

cmd/capibmadm/cmd/powervs/image/type.go Outdated Show resolved Hide resolved

Amulyam24 reviewed Mar 2, 2023

View reviewed changes

cmd/capibmadm/cmd/powervs/image/list.go Show resolved Hide resolved

Add support for powervs image list command

bcdf937

KeerthanaAP force-pushed the capibmadm-powervs-image-list branch from 2526706 to bcdf937 Compare March 2, 2023 10:03

Amulyam24 reviewed Mar 2, 2023

View reviewed changes

mkumatag approved these changes Mar 2, 2023

View reviewed changes

k8s-ci-robot assigned mkumatag Mar 2, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2023

k8s-ci-robot merged commit ef8e738 into kubernetes-sigs:main Mar 2, 2023

Karthik-K-N mentioned this pull request Mar 10, 2023

CLI tool for Cluster API Provider IBM Cloud #1052

Closed

16 tasks

KeerthanaAP deleted the capibmadm-powervs-image-list branch April 4, 2024 06:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for powervs image list command #1127

Add support for powervs image list command #1127

KeerthanaAP commented Mar 1, 2023

netlify bot commented Mar 1, 2023 •

edited

Loading

k8s-ci-robot commented Mar 1, 2023

k8s-ci-robot commented Mar 1, 2023

linux-foundation-easycla bot commented Mar 1, 2023 •

edited

Loading

Amulyam24 commented Mar 2, 2023

Amulyam24 Mar 2, 2023

Amulyam24 left a comment

mkumatag left a comment

k8s-ci-robot commented Mar 2, 2023

		}

		printerObj, err := printer.New(options.GlobalOptions.Output, os.Stdout)

Add support for powervs image list command #1127

Add support for powervs image list command #1127

Conversation

KeerthanaAP commented Mar 1, 2023

netlify bot commented Mar 1, 2023 • edited Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

k8s-ci-robot commented Mar 1, 2023

k8s-ci-robot commented Mar 1, 2023

linux-foundation-easycla bot commented Mar 1, 2023 • edited Loading

Amulyam24 commented Mar 2, 2023

Amulyam24 Mar 2, 2023

Choose a reason for hiding this comment

Amulyam24 left a comment

Choose a reason for hiding this comment

mkumatag left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Mar 2, 2023

netlify bot commented Mar 1, 2023 •

edited

Loading

linux-foundation-easycla bot commented Mar 1, 2023 •

edited

Loading