Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPC key create and delete operations added #1113

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

Madhan-SWE
Copy link
Contributor

@Madhan-SWE Madhan-SWE commented Feb 22, 2023

What this PR does / why we need it:
This is for creating and deleting key from VPC.

Create key

%./capibmadm vpc key create --name test-key --key-path /Users/madhankumar/.ssh/id_rsa.pub --region eu-de 

VPC Key created successfully, key-name="test-key"
% ./capibmadm vpc key create  --name test-key --public-key "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABgQDHeTZS7Pxr/43AG1Z0rVktiisut+XTqODsZMBFwJX3AJUmp4K21GzOYaBYreAIAZht36I7Qw8Kv5QtqMDcZl00dkQZBHR4Gs7fQUpjZh5z6yDSm2v5SjUf7POk3kixEbyUuE1o0Hik0acaEk/18r09FHuelSsB2UvaBDjbF/1EMzrgHJ8LgnH9Md+Y/I6fb4NE3Jryrs20rC5pTxCkzX2K7NYo1oduv9pkGA2tAdukCFPgX0HjXdYP1h54MJxWU/EtMgjz85HjrWH0NYrQEV+uyh1RiBeDKRzBtqqXguXIomZhB2k0WdMPSNM5G/tkXXCM1aO1ZgCzfrn1mP1xp+gzBSjTJi5oX2KPsffP5oyTd09XRWjsjcbAUZEYbcRi8dV3CwtGB8vPFqWtzoE0NUkGTe+e+y81sEPbbikUt9PM+8MQmVDzSEfxYFVem8CJfCRkE3/egfkOP4cRo+px3y4nQngJoKDmuJHjs3BbcgZNxDBCNA44FMgxhaxEUgNkkjM= [email protected]" --region "eu-de"

VPC Key created successfully, key-name="test-key"

Delete key

% ./capibmadm vpc key delete --name test-key --region eu-de

VPC Key deleted successfully, key-name="test-key"

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@k8s-ci-robot k8s-ci-robot added the area/provider/ibmcloud Issues or PRs related to ibmcloud provider label Feb 22, 2023
@netlify
Copy link

netlify bot commented Feb 22, 2023

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 9032648
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/6405d6a54779ff0008ba84eb
😎 Deploy Preview https://deploy-preview-1113--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 22, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 27, 2023
@Madhan-SWE
Copy link
Contributor Author

/retest-required

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2023
@mkumatag
Copy link
Member

mkumatag commented Mar 1, 2023

@Madhan-SWE I see #1085 as well, can you close the duplicate one, and make sure rebase the code as well.

@Madhan-SWE Madhan-SWE force-pushed the vpc-key-create-new branch from 2f84c3b to 8576719 Compare March 2, 2023 09:44
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 2, 2023
@Prajyot-Parab
Copy link
Contributor

/cc @Amulyam24

@k8s-ci-robot k8s-ci-robot requested a review from Amulyam24 March 2, 2023 10:20
@Madhan-SWE Madhan-SWE force-pushed the vpc-key-create-new branch from f454c77 to 9032648 Compare March 6, 2023 12:03
Copy link
Contributor

@Amulyam24 Amulyam24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/cc @mkumatag

@k8s-ci-robot k8s-ci-robot requested a review from mkumatag March 6, 2023 12:09
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2023
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, Madhan-SWE, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4d225ea into kubernetes-sigs:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants