Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Port Delete command to capibmadm #1086

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Added Port Delete command to capibmadm #1086

merged 1 commit into from
Feb 15, 2023

Conversation

Rajalakshmi-Girish
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 8, 2023
@netlify
Copy link

netlify bot commented Feb 8, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 6ff6c9e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/63ecadd2866709000809bd3b
😎 Deploy Preview https://deploy-preview-1086--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 8, 2023
@Rajalakshmi-Girish Rajalakshmi-Girish force-pushed the capibmadm-port-del2 branch 4 times, most recently from abedd60 to 8b0e8a5 Compare February 8, 2023 13:08
mkumatag
mkumatag requested changes Feb 8, 2023
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, otherwise lgtm

cmd/capibmadm/cmd/powervs/port/delete.go Outdated Show resolved Hide resolved
cmd/capibmadm/cmd/powervs/port/doc.go Outdated Show resolved Hide resolved
@mkumatag
Copy link
Member

mkumatag commented Feb 8, 2023

/cc @Karthik-K-N @Prajyot-Parab

Karthik-K-N
Karthik-K-N reviewed Feb 9, 2023
View reviewed changes
cmd/capibmadm/cmd/powervs/port/delete.go Outdated Show resolved Hide resolved
cmd/capibmadm/cmd/powervs/port/delete.go Outdated Show resolved Hide resolved
cmd/capibmadm/cmd/powervs/port/delete.go Outdated Show resolved Hide resolved
cmd/capibmadm/cmd/powervs/port/delete.go Outdated Show resolved Hide resolved
cmd/capibmadm/cmd/powervs/port/delete.go Outdated Show resolved Hide resolved
cmd/capibmadm/cmd/powervs/port/delete.go Outdated Show resolved Hide resolved
docs/book/src/topics/capibmadm/powervs/port.md Outdated Show resolved Hide resolved
docs/book/src/topics/capibmadm/powervs/port.md Outdated Show resolved Hide resolved
@Rajalakshmi-Girish
Copy link
Contributor Author

@Karthik-K-N I have implemented the changes suggested by you.
Can you PTAL now?

Karthik-K-N
Karthik-K-N reviewed Feb 10, 2023
View reviewed changes
Copy link
Contributor

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change otherwise LGTM

cmd/capibmadm/cmd/powervs/port/delete.go Outdated Show resolved Hide resolved
@Prajyot-Parab
Copy link
Contributor

/test all

@Karthik-K-N
Copy link
Contributor

Lets make changes to use PowerVS instead of Power VS.

Prajyot-Parab
Prajyot-Parab suggested changes Feb 10, 2023
View reviewed changes
docs/book/src/topics/capibmadm/powervs/port.md Outdated Show resolved Hide resolved
docs/book/src/topics/capibmadm/powervs/port.md Outdated Show resolved Hide resolved
docs/book/src/topics/capibmadm/powervs/port.md Outdated Show resolved Hide resolved
docs/book/src/topics/capibmadm/powervs/port.md Outdated Show resolved Hide resolved
cmd/capibmadm/cmd/powervs/port/port.go Outdated Show resolved Hide resolved
@Prajyot-Parab
Copy link
Contributor

/lgtm
PTAL @Karthik-K-N @mkumatag

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2023
@Karthik-K-N
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 14, 2023
@Rajalakshmi-Girish Rajalakshmi-Girish force-pushed the capibmadm-port-del2 branch 3 times, most recently from 1299392 to 83c1afb Compare February 15, 2023 09:51
Karthik-K-N
Karthik-K-N reviewed Feb 15, 2023
View reviewed changes
Copy link
Contributor

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion otherwise LGTM

cmd/capibmadm/cmd/powervs/port/delete.go Outdated Show resolved Hide resolved
Prajyot-Parab
Prajyot-Parab approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
cc @Karthik-K-N

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2023
@Karthik-K-N
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, Prajyot-Parab, Rajalakshmi-Girish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 71bfa91 into kubernetes-sigs:main Feb 15, 2023
@Karthik-K-N Karthik-K-N mentioned this pull request Mar 10, 2023
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karthik-K-N Karthik-K-N Karthik-K-N left review comments

@Amulyam24 Amulyam24 Amulyam24 left review comments

@Prajyot-Parab Prajyot-Parab Prajyot-Parab approved these changes

@mkumatag mkumatag mkumatag approved these changes

@jichenjc jichenjc Awaiting requested review from jichenjc

Assignees

@Karthik-K-N Karthik-K-N

@Prajyot-Parab Prajyot-Parab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Rajalakshmi-Girish @mkumatag @Prajyot-Parab @Karthik-K-N @k8s-ci-robot @Amulyam24