vpc key list command #1083

pkenchap · 2023-02-08T06:53:56Z

Signed-off-by: Punith Kenchappa [email protected]

What this PR does / why we need it:
This is for listing the key from the VPC.
O/P of this command - vpc key list --region jp-osa

punithkenchappa@Puniths-MacBook-Pro-2 cluster-api-provider-ibmcloud % ./capibmadm vpc key list --region jp-osa
ID                                          NAME         TYPE   CREATED AT                 LENGTH   FINGERPRINT                                          RESOURCE GROUP
r034-5b5d022b-220e-4525-b6ef-274d41de7065   dhar-ssh     rsa    2022-06-23T07:06:45.000Z   4096     SHA256:JSp4g1DXZBr3rw+dIX1eIwCjl3/hNJrgcWqPlHv0QNg   ibm-hypershift-dev
r034-705a00a0-8eca-43a9-8014-9dfa7fbf8ab3   amulya-key   rsa    2022-08-29T11:11:57.000Z   4096     SHA256:E7RraXBL67IW22z44M0XbFc/hHvS2rqM1d/l4+U7Udw   Default


**Json output**

punithkenchappa@Puniths-MacBook-Pro-2 cluster-api-provider-ibmcloud % ./capibmadm vpc key list --region jp-osa --output json
[
  {
    "id": "r034-5b5d022b-220e-4525-b6ef-274d41de7065",
    "created_at": "2022-06-23T07:06:45.000Z",
    "name": "dhar-ssh",
    "type": "rsa",
    "resourceGroup": "ibm-hypershift-dev",
    "fingerPrint": "SHA256:JSp4g1DXZBr3rw+dIX1eIwCjl3/hNJrgcWqPlHv0QNg",
    "length": 4096
  },
  {
    "id": "r034-705a00a0-8eca-43a9-8014-9dfa7fbf8ab3",
    "created_at": "2022-08-29T11:11:57.000Z",
    "name": "amulya-key",
    "type": "rsa",
    "resourceGroup": "Default",
    "fingerPrint": "SHA256:E7RraXBL67IW22z44M0XbFc/hHvS2rqM1d/l4+U7Udw",
    "length": 4096
  }
]%

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

linux-foundation-easycla · 2023-02-08T06:53:59Z

The committers listed above are authorized under a signed CLA.

✅ login: pkenchap (626c20e)

netlify · 2023-02-08T06:54:02Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name	Link
🔨 Latest commit	`e33491b`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/63fc4467d5b80a0008001077
😎 Deploy Preview	https://deploy-preview-1083--kubernetes-sigs-cluster-api-ibmcloud.netlify.app/print
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

k8s-ci-robot · 2023-02-08T06:54:04Z

Welcome @pkenchap!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-ibmcloud 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-ibmcloud has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-02-08T06:54:06Z

Hi @pkenchap. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Prajyot-Parab · 2023-02-08T07:01:53Z

/ok-to-test

Prajyot-Parab · 2023-02-09T06:38:55Z

@pkenchap Need to update docs here - Doc ref
For more info, you can refer to Kishen's PR, reach out to me for any queries

Prajyot-Parab · 2023-02-09T10:38:05Z

/cc @Karthik-K-N ptal

k8s-ci-robot · 2023-02-09T10:38:09Z

@Prajyot-Parab: GitHub didn't allow me to request PR reviews from the following users: ptal.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @Karthik-K-N ptal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cmd/capibmadm/cmd/vpc/key/list.go

cmd/capibmadm/cmd/vpc/key/type.go

cmd/capibmadm/cmd/vpc/doc

cmd/capibmadm/cmd/vpc/vpc.go

cmd/capibmadm/cmd/vpc/key/list.go

Prajyot-Parab · 2023-02-10T05:26:34Z

/retest all

k8s-ci-robot · 2023-02-10T05:26:36Z

@Prajyot-Parab: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-ccm-image
/test pull-cluster-api-provider-ibmcloud-build
/test pull-cluster-api-provider-ibmcloud-coverage
/test pull-cluster-api-provider-ibmcloud-make
/test pull-cluster-api-provider-ibmcloud-smoke-test
/test pull-cluster-api-provider-ibmcloud-test
/test pull-cluster-api-provider-ibmcloud-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-ibmcloud-apidiff

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-ibmcloud-apidiff
pull-cluster-api-provider-ibmcloud-build
pull-cluster-api-provider-ibmcloud-coverage
pull-cluster-api-provider-ibmcloud-make
pull-cluster-api-provider-ibmcloud-smoke-test
pull-cluster-api-provider-ibmcloud-test
pull-cluster-api-provider-ibmcloud-verify

In response to this:

/retest all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Prajyot-Parab · 2023-02-10T05:27:45Z

/test all

Prajyot-Parab · 2023-02-14T16:03:23Z

@pkenchap Add the missing docs and fix ci failures.

dharaneeshvrd

A single nit, otherwise LGTM

cmd/capibmadm/cmd/vpc/vpc.go

mkumatag

one minor comment

cmd/capibmadm/cmd/vpc/key/list.go

Karthik-K-N

Small suggestion otherwise LGTM

cmd/capibmadm/cmd/vpc/doc

Karthik-K-N · 2023-02-21T06:43:24Z

cmd/capibmadm/cmd/vpc/key/list.go

+		}
+	}
+
+	p, err := printer.New(options.GlobalOptions.Output, os.Stdout)


may be some other name rather than p?

docs/book/src/topics/capibmadm/vpc/key.md

cmd/capibmadm/cmd/vpc/key/type.go

Signed-off-by: Punith Kenchappa <[email protected]>

dharaneeshvrd · 2023-02-27T06:04:30Z

code LGTM!

Karthik-K-N · 2023-02-27T06:11:34Z

/lgtm

mkumatag

/lgtm

k8s-ci-robot · 2023-03-01T04:31:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, pkenchap, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mkumatag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the area/provider/ibmcloud Issues or PRs related to ibmcloud provider label Feb 8, 2023

k8s-ci-robot requested review from gyliu513 and jichenjc February 8, 2023 06:54

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 8, 2023

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 8, 2023

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 8, 2023

k8s-ci-robot requested a review from Karthik-K-N February 9, 2023 10:38

Karthik-K-N reviewed Feb 9, 2023

View reviewed changes

cmd/capibmadm/cmd/vpc/key/list.go Outdated Show resolved Hide resolved

Amulyam24 reviewed Feb 9, 2023

View reviewed changes

cmd/capibmadm/cmd/vpc/key/type.go Outdated Show resolved Hide resolved

Prajyot-Parab reviewed Feb 9, 2023

View reviewed changes

cmd/capibmadm/cmd/vpc/doc Outdated Show resolved Hide resolved

Prajyot-Parab reviewed Feb 9, 2023

View reviewed changes

cmd/capibmadm/cmd/vpc/vpc.go Outdated Show resolved Hide resolved

Prajyot-Parab reviewed Feb 9, 2023

View reviewed changes

cmd/capibmadm/cmd/vpc/key/list.go Outdated Show resolved Hide resolved

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 11, 2023

dharaneeshvrd reviewed Feb 20, 2023

View reviewed changes

cmd/capibmadm/cmd/vpc/vpc.go Outdated Show resolved Hide resolved

pkenchap requested review from dharaneeshvrd and Karthik-K-N and removed request for gyliu513, mkumatag, jichenjc, Karthik-K-N and dharaneeshvrd February 21, 2023 06:34

mkumatag requested changes Feb 21, 2023

View reviewed changes

cmd/capibmadm/cmd/vpc/key/list.go Outdated Show resolved Hide resolved

Karthik-K-N reviewed Feb 21, 2023

View reviewed changes

dharaneeshvrd reviewed Feb 21, 2023

View reviewed changes

docs/book/src/topics/capibmadm/vpc/key.md Outdated Show resolved Hide resolved

cmd/capibmadm/cmd/vpc/key/type.go Outdated Show resolved Hide resolved

pkenchap requested review from mkumatag, dharaneeshvrd and Karthik-K-N and removed request for mkumatag, dharaneeshvrd and Karthik-K-N February 21, 2023 12:08

vpc key list command

e33491b

Signed-off-by: Punith Kenchappa <[email protected]>

k8s-ci-robot assigned Karthik-K-N Feb 27, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2023

mkumatag approved these changes Mar 1, 2023

View reviewed changes

k8s-ci-robot assigned mkumatag Mar 1, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2023

k8s-ci-robot merged commit fb9927d into kubernetes-sigs:main Mar 1, 2023

Karthik-K-N mentioned this pull request Mar 10, 2023

CLI tool for Cluster API Provider IBM Cloud #1052

Closed

16 tasks

dharaneeshvrd mentioned this pull request Mar 22, 2023

REQUEST: New membership for dharaneeshvrd kubernetes/org#4107

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vpc key list command #1083

vpc key list command #1083

pkenchap commented Feb 8, 2023

linux-foundation-easycla bot commented Feb 8, 2023 •

edited

Loading

netlify bot commented Feb 8, 2023 •

edited

Loading

k8s-ci-robot commented Feb 8, 2023

k8s-ci-robot commented Feb 8, 2023

Prajyot-Parab commented Feb 8, 2023

Prajyot-Parab commented Feb 9, 2023

Prajyot-Parab commented Feb 9, 2023

k8s-ci-robot commented Feb 9, 2023

Prajyot-Parab commented Feb 10, 2023

k8s-ci-robot commented Feb 10, 2023

Prajyot-Parab commented Feb 10, 2023

Prajyot-Parab commented Feb 14, 2023

dharaneeshvrd left a comment

mkumatag left a comment

Karthik-K-N left a comment

Karthik-K-N Feb 21, 2023

dharaneeshvrd commented Feb 27, 2023

Karthik-K-N commented Feb 27, 2023

mkumatag left a comment

k8s-ci-robot commented Mar 1, 2023

vpc key list command #1083

vpc key list command #1083

Conversation

pkenchap commented Feb 8, 2023

linux-foundation-easycla bot commented Feb 8, 2023 • edited Loading

netlify bot commented Feb 8, 2023 • edited Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

k8s-ci-robot commented Feb 8, 2023

k8s-ci-robot commented Feb 8, 2023

Prajyot-Parab commented Feb 8, 2023

Prajyot-Parab commented Feb 9, 2023

Prajyot-Parab commented Feb 9, 2023

k8s-ci-robot commented Feb 9, 2023

Prajyot-Parab commented Feb 10, 2023

k8s-ci-robot commented Feb 10, 2023

Prajyot-Parab commented Feb 10, 2023

Prajyot-Parab commented Feb 14, 2023

dharaneeshvrd left a comment

Choose a reason for hiding this comment

mkumatag left a comment

Choose a reason for hiding this comment

Karthik-K-N left a comment

Choose a reason for hiding this comment

Karthik-K-N Feb 21, 2023

Choose a reason for hiding this comment

dharaneeshvrd commented Feb 27, 2023

Karthik-K-N commented Feb 27, 2023

mkumatag left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Mar 1, 2023

linux-foundation-easycla bot commented Feb 8, 2023 •

edited

Loading

netlify bot commented Feb 8, 2023 •

edited

Loading