-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance deletion logic #1805
Comments
/good-first-issue |
@Amulyam24: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign |
Planning to fix couple of issues along with this
|
@Amulyam24 Is it ok to address the above issues also in this issue, or is it better to create a separate issue? wdyt? |
Sure, we can handle it as a part of this issue with detailed description and separate commits in PR if needed as it comes under the umbrella of enhancing the deletion logic.
For this, I recently added a change in the PR. If additional checks are required, feel free to add the enhancements in your PR. |
/kind feature
/area provider/ibmcloud
Describe the solution you'd like
We are currently fetching the resource and checking against a text phrase if it is successfully deleted(eg: VPC), leverage using http status codes instead.
This is applicable to
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
The text was updated successfully, but these errors were encountered: