Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance deletion logic #1805

Closed
2 tasks
Amulyam24 opened this issue May 27, 2024 · 6 comments · Fixed by #1825
Closed
2 tasks

Enhance deletion logic #1805

Amulyam24 opened this issue May 27, 2024 · 6 comments · Fixed by #1825
Assignees
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@Amulyam24
Copy link
Contributor

/kind feature
/area provider/ibmcloud

Describe the solution you'd like
We are currently fetching the resource and checking against a text phrase if it is successfully deleted(eg: VPC), leverage using http status codes instead.
This is applicable to

  • VPC resources(VPC, load balancer, subnet, security groups)
  • Transit gateway

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels May 27, 2024
@Amulyam24
Copy link
Contributor Author

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@Amulyam24:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels May 27, 2024
@dharaneeshvrd
Copy link
Contributor

/assign

@dharaneeshvrd
Copy link
Contributor

Planning to fix couple of issues along with this

  1. Observed that when DHCP server deletion throws error it did nt get logged and powervs deletion is also stuck with waiting for dhcp server to get deleted.
  2. Usually powervs instance deletion will not get deleted in first attempt, need to retry after sometime. So need to add requeue logic to Retrying the delete, until it succeeds.

@dharaneeshvrd
Copy link
Contributor

@Amulyam24 Is it ok to address the above issues also in this issue, or is it better to create a separate issue? wdyt?

@Amulyam24
Copy link
Contributor Author

Sure, we can handle it as a part of this issue with detailed description and separate commits in PR if needed as it comes under the umbrella of enhancing the deletion logic.

  1. Usually powervs instance deletion will not get deleted in first attempt, need to retry after sometime. So need to add requeue logic to Retrying the delete, until it succeeds.

For this, I recently added a change in the PR. If additional checks are required, feel free to add the enhancements in your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants