Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unit tests for record.go #1198

Closed
khareyash05 opened this issue Apr 25, 2023 · 0 comments · Fixed by #1302
Closed

add unit tests for record.go #1198

khareyash05 opened this issue Apr 25, 2023 · 0 comments · Fixed by #1302
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Milestone
Next

Comments

@khareyash05
Copy link
Member

/kind feature
/area provider/ibmcloud

Describe the solution you'd like
I would like to add unit tests for pkg/record/record.go

Anything else you would like to add:
NA
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels Apr 25, 2023
@mkumatag mkumatag added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels May 19, 2023
@mkumatag mkumatag added this to the Next milestone May 19, 2023
Anddd7 added a commit to Anddd7/cluster-api-provider-ibmcloud that referenced this issue Jul 19, 2023
@Anddd7
fix kubernetes-sigs#1198, add unit test for record.go
3cd128a
Anddd7 added a commit to Anddd7/cluster-api-provider-ibmcloud that referenced this issue Jul 19, 2023
@Anddd7
fix kubernetes-sigs#1198, add unit test for record.go
6d3bc26 
Signed-off-by: Anddd7 <[email protected]>
Anddd7 added a commit to Anddd7/cluster-api-provider-ibmcloud that referenced this issue Jul 19, 2023
@Anddd7
fix kubernetes-sigs#1198, add unit test for record.go
a339e2c 
Signed-off-by: Anddd7 <[email protected]>
@Anddd7 Anddd7 mentioned this issue Jul 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
Next
Development

Successfully merging a pull request may close this issue.

Add unit test for record.go Anddd7/cluster-api-provider-ibmcloud
3 participants
@mkumatag @k8s-ci-robot @khareyash05