Change IBMPowerVSClient type for better mocking

PowerVS client would be mocked for unit tests. gomock expects the mocked type to be an interface, hence change the IBMPowerVSClient to be of type PowerVS. Signed-off-by: Amulyam24 <[email protected]>
kubernetes-sigs · Feb 24, 2022 · e89d71c · e89d71c
1 parent d83617b
commit e89d71c
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/cloud/scope/powervs_cluster.go b/cloud/scope/powervs_cluster.go
@@ -58,7 +58,7 @@ type PowerVSClusterScope struct {
 	client      client.Client
 	patchHelper *patch.Helper
 
-	IBMPowerVSClient  *powervs.Service
+	IBMPowerVSClient  powervs.PowerVS
 	Cluster           *clusterv1.Cluster
 	IBMPowerVSCluster *v1beta1.IBMPowerVSCluster
 }

diff --git a/cloud/scope/powervs_image.go b/cloud/scope/powervs_image.go
@@ -55,7 +55,7 @@ type PowerVSImageScope struct {
 	client      client.Client
 	patchHelper *patch.Helper
 
-	IBMPowerVSClient *powervs.Service
+	IBMPowerVSClient powervs.PowerVS
 	IBMPowerVSImage  *v1beta1.IBMPowerVSImage
 }
 

diff --git a/cloud/scope/powervs_machine.go b/cloud/scope/powervs_machine.go
@@ -65,7 +65,7 @@ type PowerVSMachineScope struct {
 	client      client.Client
 	patchHelper *patch.Helper
 
-	IBMPowerVSClient  *powervs.Service
+	IBMPowerVSClient  powervs.PowerVS
 	Cluster           *clusterv1.Cluster
 	Machine           *clusterv1.Machine
 	IBMPowerVSCluster *v1beta1.IBMPowerVSCluster

diff --git a/pkg/cloud/services/powervs/service.go b/pkg/cloud/services/powervs/service.go
@@ -110,7 +110,7 @@ func (s *Service) GetAllNetwork() (*models.Networks, error) {
 }
 
 // NewService returns a new service for the Power VS api client.
-func NewService(options ServiceOptions) (*Service, error) {
+func NewService(options ServiceOptions) (PowerVS, error) {
 	auth, err := authenticator.GetAuthenticator()
 	if err != nil {
 		return nil, err