Adding more addresses to the machine spec

kubernetes-sigs · Feb 16, 2022 · 9f028a7 · 9f028a7
1 parent 3e35b89
commit 9f028a7
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/cloud/scope/powervs_machine.go b/cloud/scope/powervs_machine.go
@@ -360,9 +360,18 @@ func (m *PowerVSMachineScope) SetHealth(health *models.PVMInstanceHealth) {
 	}
 }
 
-func (m *PowerVSMachineScope) SetAddresses(networks []*models.PVMInstanceNetwork) {
+func (m *PowerVSMachineScope) SetAddresses(instance *models.PVMInstance) {
 	var addresses []corev1.NodeAddress
-	for _, network := range networks {
+	// Setting the name of the vm to the InternalDNS and Hostname as the vm uses that as hostname
+	addresses = append(addresses, corev1.NodeAddress{
+		Type:    corev1.NodeInternalDNS,
+		Address: *instance.ServerName,
+	})
+	addresses = append(addresses, corev1.NodeAddress{
+		Type:    corev1.NodeHostName,
+		Address: *instance.ServerName,
+	})
+	for _, network := range instance.Networks {
 		addresses = append(addresses, corev1.NodeAddress{
 			Type:    corev1.NodeInternalIP,
 			Address: network.IPAddress,

diff --git a/controllers/ibmpowervsmachine_controller.go b/controllers/ibmpowervsmachine_controller.go
@@ -206,7 +206,7 @@ func (r *IBMPowerVSMachineReconciler) reconcileNormal(ctx context.Context, machi
 			return ctrl.Result{}, err
 		}
 		machineScope.SetInstanceID(instance.PvmInstanceID)
-		machineScope.SetAddresses(instance.Networks)
+		machineScope.SetAddresses(instance)
 		machineScope.SetHealth(instance.Health)
 		machineScope.SetInstanceState(instance.Status)
 		switch machineScope.GetInstanceState() {