Skip to content

Commit

Permalink
Update PortRange and ICMP types for Security Groups (#1752)
Browse files Browse the repository at this point in the history
Update the types for PortRange fields and for ICMP fields in the
Security Groups, to make setting and checking easier.
  • Loading branch information
cjschaef authored May 10, 2024
1 parent b4e0e2a commit 99c905a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions api/v1beta2/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -260,12 +260,12 @@ type PortRange struct {
// maximumPort is the inclusive upper range of ports.
// +kubebuilder:validation:Minimum=1
// +kubebuilder:validation:Maximum=65535
MaximumPort int `json:"maximumPort,omitempty"`
MaximumPort int64 `json:"maximumPort,omitempty"`

// minimumPort is the inclusive lower range of ports.
// +kubebuilder:validation:Minimum=1
// +kubebuilder:validation:Maximum=65535
MinimumPort int `json:"minimumPort,omitempty"`
MinimumPort int64 `json:"minimumPort,omitempty"`
}

// SecurityGroup defines a VPC Security Group that should exist or be created within the specified VPC, with the specified Security Group Rules.
Expand Down Expand Up @@ -361,12 +361,12 @@ type SecurityGroupRulePrototype struct {
// icmpCode is the ICMP code for the Rule.
// Only used when Protocol is SecurityGroupProtocolICMP.
// +optional
ICMPCode *string `json:"icmpCode,omitempty"`
ICMPCode *int64 `json:"icmpCode,omitempty"`

// icmpType is the ICMP type for the Rule.
// Only used when Protocol is SecurityGroupProtocolICMP.
// +optional
ICMPType *string `json:"icmpType,omitempty"`
ICMPType *int64 `json:"icmpType,omitempty"`

// portRange is a range of ports allowed for the Rule's remote.
// +optional
Expand Down
4 changes: 2 additions & 2 deletions api/v1beta2/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 99c905a

Please sign in to comment.