Skip to content

Commit

Permalink
misc review changes
Browse files Browse the repository at this point in the history
Signed-off-by: Yussuf Shaikh <[email protected]>
  • Loading branch information
yussufsh committed Mar 14, 2023
1 parent 8961508 commit 7bdd0ef
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion cmd/capibmadm/cmd/powervs/network/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ Private network with ip address ranges: capibmadm powervs network create --priva

func createNetwork(ctx context.Context, netCreateOption networkCreateOptions) error {
log := logf.Log
log.Info("Creating Power VS network", "service-instance-id", options.GlobalOptions.ServiceInstanceID, "zone", options.GlobalOptions.PowerVSZone)
log.Info("Creating PowerVS network", "service-instance-id", options.GlobalOptions.ServiceInstanceID, "zone", options.GlobalOptions.PowerVSZone)

accountID, err := utils.GetAccountID(ctx, iam.GetIAMAuth())
if err != nil {
Expand Down
4 changes: 2 additions & 2 deletions cmd/capibmadm/cmd/powervs/network/delete.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import (
"sigs.k8s.io/cluster-api-provider-ibmcloud/cmd/capibmadm/utils"
)

// DeleteCommand function to delete network's port.
// DeleteCommand function to delete network.
func DeleteCommand() *cobra.Command {
cmd := &cobra.Command{
Use: "delete",
Expand All @@ -54,7 +54,7 @@ capibmadm powervs network delete --network <network-name/network-id> --service-i

func deleteNetwork(ctx context.Context, networkID string) error {
log := logf.Log
log.Info("Deleting Power VS network", "service-instance-id", options.GlobalOptions.ServiceInstanceID, "zone", options.GlobalOptions.PowerVSZone)
log.Info("Deleting PowerVS network", "service-instance-id", options.GlobalOptions.ServiceInstanceID, "zone", options.GlobalOptions.PowerVSZone)

accountID, err := utils.GetAccountID(ctx, iam.GetIAMAuth())
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion docs/book/src/topics/capibmadm/powervs/index.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# capibmadm powervs `<commands>`


## 1. Power VS commands
## 1. PowerVS commands
- [key](./key.md)
- [create](/topics/capibmadm/powervs/key.html#1-capibmadm-powervs-key-create)
- [delete](/topics/capibmadm/powervs/key.html#2-capibmadm-powervs-key-delete)
Expand Down
10 changes: 5 additions & 5 deletions docs/book/src/topics/capibmadm/powervs/network.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
## Power VS Network Commands
## PowerVS Network Commands

### 1. capibmadm powervs network create

#### Usage:
Create PowerVS network.

#### Environmental Variable:
IBMCLOUD_API_KEY: IBM Cloud api key.
IBMCLOUD_API_KEY: IBM Cloud API key.

#### Arguments:
--service-instance-id: Power VS service instance id.
--service-instance-id: PowerVS service instance id.

--cidr: The network CIDR. Required for private network type.

Expand Down Expand Up @@ -46,7 +46,7 @@ capibmadm powervs network create --private --cidr <cidr> --ip-ranges <start-ip>-
Delete PowerVS network.

#### Environmental Variable:
IBMCLOUD_API_KEY: IBM Cloud api key.
IBMCLOUD_API_KEY: IBM Cloud API key.

#### Arguments:
--service-instance-id: PowerVS service instance id.
Expand All @@ -68,7 +68,7 @@ capibmadm powervs network delete --network <network-name/network-id> --service-i
List PowerVS networks.

#### Environmental Variable:
IBMCLOUD_API_KEY: IBM Cloud api key.
IBMCLOUD_API_KEY: IBM Cloud API key.

#### Arguments:
--service-instance-id: PowerVS service instance id.
Expand Down

0 comments on commit 7bdd0ef

Please sign in to comment.