Register the errors for the powervs vm build failure

kubernetes-sigs · May 5, 2022 · 4e4a48e · 4e4a48e
1 parent 38f7d43
commit 4e4a48e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/cloud/scope/powervs_machine.go b/cloud/scope/powervs_machine.go
@@ -36,6 +36,7 @@ import (
 	"k8s.io/klog/v2/klogr"
 	"k8s.io/utils/pointer"
 	capiv1beta1 "sigs.k8s.io/cluster-api/api/v1beta1"
+	capierrors "sigs.k8s.io/cluster-api/errors"
 	"sigs.k8s.io/cluster-api/util/patch"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 
@@ -355,6 +356,16 @@ func (m *PowerVSMachineScope) SetNotReady() {
 	m.IBMPowerVSMachine.Status.Ready = false
 }
 
+// SetFailureReason will set status FailureReason for the machine.
+func (m *PowerVSMachineScope) SetFailureReason(reason capierrors.MachineStatusError) {
+	m.IBMPowerVSMachine.Status.FailureReason = &reason
+}
+
+// SetFailureMessage will set status FailureMessage for the machine.
+func (m *PowerVSMachineScope) SetFailureMessage(message string) {
+	m.IBMPowerVSMachine.Status.FailureMessage = &message
+}
+
 // IsReady will return the status for the machine.
 func (m *PowerVSMachineScope) IsReady() bool {
 	return m.IBMPowerVSMachine.Status.Ready

diff --git a/controllers/ibmpowervsmachine_controller.go b/controllers/ibmpowervsmachine_controller.go
@@ -27,6 +27,7 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/client-go/tools/record"
 	capiv1beta1 "sigs.k8s.io/cluster-api/api/v1beta1"
+	capierrors "sigs.k8s.io/cluster-api/errors"
 	"sigs.k8s.io/cluster-api/util"
 	"sigs.k8s.io/cluster-api/util/conditions"
 	ctrl "sigs.k8s.io/controller-runtime"
@@ -228,6 +229,8 @@ func (r *IBMPowerVSMachineReconciler) reconcileNormal(machineScope *scope.PowerV
 				msg = instance.Fault.Details
 			}
 			machineScope.SetNotReady()
+			machineScope.SetFailureReason(capierrors.UpdateMachineError)
+			machineScope.SetFailureMessage(msg)
 			conditions.MarkFalse(machineScope.IBMPowerVSMachine, infrav1beta1.InstanceReadyCondition, infrav1beta1.InstanceErroredReason, capiv1beta1.ConditionSeverityError, msg)
 			capibmrecord.Warnf(machineScope.IBMPowerVSMachine, "FailedBuildInstance", "Failed to build the instance - %s", msg)
 			return ctrl.Result{}, nil