Skip to content

Commit

Permalink
Ports list command implementation - PowerVS
Browse files Browse the repository at this point in the history
  • Loading branch information
Niharika0306 committed Feb 8, 2023
1 parent 7399387 commit 4dbc352
Show file tree
Hide file tree
Showing 9 changed files with 311 additions and 0 deletions.
18 changes: 18 additions & 0 deletions cmd/capibmadm/cmd/powervs/port/doc.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
/*
Copyright 2023 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

// Package port contains the commands to operate on Power VS Network Port resources.
package port
137 changes: 137 additions & 0 deletions cmd/capibmadm/cmd/powervs/port/list.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,137 @@
/*
Copyright 2023 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package port

import (
"context"
"fmt"
"os"

"github.com/spf13/cobra"

powerClient "github.com/IBM-Cloud/power-go-client/clients/instance"

logf "sigs.k8s.io/cluster-api/cmd/clusterctl/log"

"sigs.k8s.io/cluster-api-provider-ibmcloud/cmd/capibmadm/clients/iam"
"sigs.k8s.io/cluster-api-provider-ibmcloud/cmd/capibmadm/clients/powervs"
"sigs.k8s.io/cluster-api-provider-ibmcloud/cmd/capibmadm/options"
"sigs.k8s.io/cluster-api-provider-ibmcloud/cmd/capibmadm/printer"
"sigs.k8s.io/cluster-api-provider-ibmcloud/cmd/capibmadm/utils"
)

var network string

// ListCommand powervs port list command.
func ListCommand() *cobra.Command {
cmd := &cobra.Command{
Use: "list",
Short: "List PowerVS ports",
Example: `
# List ports in PowerVS Network
export IBMCLOUD_API_KEY=<api-key>
capibmadm powervs port list --instance-id <service-instance-id> --network <network ID or name>`,
}

cmd.Flags().StringVar(&network, "network", "", "Network ID or Name(preference will be given to the ID over Name)")
_ = cmd.MarkFlagRequired("network")

cmd.RunE = func(cmd *cobra.Command, args []string) error {
if err := listPorts(cmd.Context(), network); err != nil {
return err
}
return nil
}

return cmd
}

func listPorts(ctx context.Context, network string) error {

log := logf.Log
log.Info("Listing PowerVS ports", "service-instance-id", options.GlobalOptions.ServiceInstanceID, "network", network)

auth := iam.GetIAMAuth()
accountID, _ := utils.GetAccountID(ctx, auth)
sess, err := powervs.NewPISession(accountID, options.GlobalOptions.PowerVSZone, options.GlobalOptions.Debug)
if err != nil {
return err
}

c := powerClient.NewIBMPINetworkClient(ctx, sess, options.GlobalOptions.ServiceInstanceID)
networks, err := c.GetAll()
if err != nil {
return fmt.Errorf("failed to get the networks, err: %v", err)
}

var networkNames, networkIDs []string
for _, net := range networks.Networks {
networkIDs = append(networkIDs, *net.NetworkID)
networkNames = append(networkNames, *net.Name)
}

var netID string

// To get the network ID in case network name is passed
if utils.Contains(networkIDs, network) {
netID = network
} else if utils.Contains(networkNames, network) {
for _, n := range networks.Networks {
if *n.Name == network {
netID = *n.NetworkID
}
}
} else {

return fmt.Errorf("Not able to find network: \"%s\" by ID or name in the network list", network)
}

portsList, err := c.GetAllPorts(netID)
if err != nil {
return err
}

listByVersion := PortList{
Items: []PortSpec{},
}

for _, port := range portsList.Ports {
listByVersion.Items = append(listByVersion.Items, PortSpec{
Description: *port.Description,
ExternalIP: port.ExternalIP,
IPAddress: *port.IPAddress,
MacAddress: *port.MacAddress,
PortID: *port.PortID,
Status: *port.Status,
})

}

printerObj, err := printer.New(options.GlobalOptions.Output, os.Stdout)
if err != nil {
return fmt.Errorf("failed creating output printer: %w", err)
}

if options.GlobalOptions.Output == printer.PrinterTypeTable {
table := listByVersion.ToTable()
printerObj.Print(table)
} else {
printerObj.Print(listByVersion)
}

return nil
}
36 changes: 36 additions & 0 deletions cmd/capibmadm/cmd/powervs/port/port.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
/*
Copyright 2023 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package port

import (
"github.com/spf13/cobra"

"sigs.k8s.io/cluster-api-provider-ibmcloud/cmd/capibmadm/options"
)

// Commands function to add PowerVS port commands.
func Commands() *cobra.Command {
cmd := &cobra.Command{
Use: "port",
Short: "Perform PowerVS port operations",
}
options.AddCommonFlags(cmd)

cmd.AddCommand(ListCommand())

return cmd
}
84 changes: 84 additions & 0 deletions cmd/capibmadm/cmd/powervs/port/type.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
/*
Copyright 2023 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package port

import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)

// PortSpec defines a port
type PortSpec struct {
// NetworkID string `json:"id"`
// Name string `json:"name"`
// Type string `json:"type"`
// VlanID float64 `json:"vlanID"`
// Jumbo bool `json:"jumbo"`
// DhcpManaged bool `json:"dhcpManaged,omitempty"`

PortID string `json:"id"`
Description string `json:"description"`
ExternalIP string `json:"externalIP,omitempty"`
IPAddress string `json:"ipAddress"`
MacAddress string `json:"macAddress"`
Status string `json:"status"`
}

// PortList defines a list of Ports.
type PortList struct {
Items []PortSpec `json:"items"`
}

// ToTable converts List to *metav1.Table.
func (portList *PortList) ToTable() *metav1.Table {
table := &metav1.Table{
TypeMeta: metav1.TypeMeta{
APIVersion: metav1.SchemeGroupVersion.String(),
Kind: "Table",
},
ColumnDefinitions: []metav1.TableColumnDefinition{
{
Name: "DESCRIPTION",
Type: "string",
},
{
Name: "EXTERNALIP",
Type: "string",
},
{
Name: "IPADDRESS",
Type: "string",
},
{
Name: "MACADDRESS",
Type: "string",
},
{
Name: "PORTID",
Type: "string",
},
{
Name: "STATUS",
Type: "string",
},
},
}

for _, port := range portList.Items {
row := metav1.TableRow{
Cells: []interface{}{port.Description, port.ExternalIP, port.IPAddress, port.MacAddress, port.PortID, port.Status},
}
table.Rows = append(table.Rows, row)
}
return table
}
2 changes: 2 additions & 0 deletions cmd/capibmadm/cmd/powervs/powervs.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"github.com/spf13/cobra"

"sigs.k8s.io/cluster-api-provider-ibmcloud/cmd/capibmadm/cmd/powervs/network"
"sigs.k8s.io/cluster-api-provider-ibmcloud/cmd/capibmadm/cmd/powervs/port"
"sigs.k8s.io/cluster-api-provider-ibmcloud/cmd/capibmadm/options"
)

Expand All @@ -38,6 +39,7 @@ func Commands() *cobra.Command {
_ = cmd.MarkPersistentFlagRequired("zone")

cmd.AddCommand(network.Commands())
cmd.AddCommand(port.Commands())

return cmd
}
9 changes: 9 additions & 0 deletions cmd/capibmadm/utils/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -111,3 +111,12 @@ func DereferencePointer(value interface{}) interface{} {
}
return nil
}

func Contains(s []string, e string) bool {
for _, a := range s {
if a == e {
return true
}
}
return false
}
1 change: 1 addition & 0 deletions docs/book/src/SUMMARY.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
- [capibmadm CLI](./topics/capibmadm/index.md)
- [Power VS Commands](./topics/capibmadm/powervs/index.md)
- [Network Commands](./topics/capibmadm/powervs/network.md)
- [Port Commands](./topics/capibmadm/powervs/port.md)
- [Developer Guide](./developer/index.md)
- [Rapid iterative development with Tilt](./developer/tilt.md)
- [Guide for API conversions](./developer/conversion.md)
Expand Down
2 changes: 2 additions & 0 deletions docs/book/src/topics/capibmadm/powervs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,5 @@
- [network](./network.md)
- [create](/topics/capibmadm/powervs/network.html#1-capibmadm-powervs-network-create)
- [list](/topics/capibmadm/powervs/network.html#2-capibmadm-powervs-network-list)
- [port](./port.md)
- [list](/topics/capibmadm/powervs/port.html#1-capibmadm-powervs-port-list)
22 changes: 22 additions & 0 deletions docs/book/src/topics/capibmadm/powervs/port.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
## Power VS Network Commands

### 1. capibmadm powervs port list

#### Usage:
List Power VS ports.

#### Environmental Variable:
IBMCLOUD_API_KEY: IBM Cloud api key.

#### Arguments:
--service-instance-id: Power VS service instance id.

--zone: Power VS zone

--network: Network ID or Name(preference will be given to the ID over Name)

#### Example:
```shell
export IBMCLOUD_API_KEY=<api-key>
capibmadm powervs port list --service-instance-id <service-instance-id> --zone <zone> --network <network>
```

0 comments on commit 4dbc352

Please sign in to comment.