make SERVICE_ENDPOINT variable optional (#839)

Signed-off-by: Prajyot-Parab <[email protected]> Signed-off-by: Prajyot-Parab <[email protected]> Co-authored-by: Prajyot-Parab <[email protected]>
kubernetes-sigs · Sep 8, 2022 · 31edb26 · 31edb26
1 parent 8c2810a
commit 31edb26
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/config/manager/manager.yaml b/config/manager/manager.yaml
@@ -29,7 +29,7 @@ spec:
         - "--leader-elect"
         - "--metrics-bind-addr=127.0.0.1:8080"
         - "--powervs-provider-id-fmt=${POWERVS_PROVIDER_ID_FORMAT:=v1}"
-        - "--service-endpoint=${SERVICE_ENDPOINT:=}"
+        - "--service-endpoint=${SERVICE_ENDPOINT:=none}"
         - "--v=${LOGLEVEL:=0}"
         image: controller:latest
         name: manager

diff --git a/pkg/endpoints/endpoints.go b/pkg/endpoints/endpoints.go
@@ -57,7 +57,7 @@ var (
 // ParseServiceEndpointFlag parses the command line flag of service endpoint in the format ${ServiceRegion}:${ServiceID1}=${URL1},${ServiceID2}=${URL2...}
 // returning a list of ServiceEndpoint.
 func ParseServiceEndpointFlag(serviceEndpoints string) ([]ServiceEndpoint, error) {
-	if serviceEndpoints == "" {
+	if serviceEndpoints == "" || serviceEndpoints == "none" {
 		return nil, nil
 	}
 

diff --git a/pkg/endpoints/endpoints_test.go b/pkg/endpoints/endpoints_test.go
@@ -35,6 +35,12 @@ func TestParseFlags(t *testing.T) {
 			expectedOutput: nil,
 			expectedError:  nil,
 		},
+		{
+			name:           "none configuration",
+			flagToParse:    "none",
+			expectedOutput: nil,
+			expectedError:  nil,
+		},
 		{
 			name:        "single region, single vpc service",
 			flagToParse: "eu-gb:vpc=https://vpchost:8080",