Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update images and k8s dependencies #931

Merged
merged 4 commits into from
Jun 7, 2023
Merged

Update images and k8s dependencies #931

merged 4 commits into from
Jun 7, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented May 26, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Update images and k8s dependencies

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 26, 2023
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 26, 2023
@cpanato
Copy link
Member Author

cpanato commented May 26, 2023

/hold for all tests

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2023
@k8s-ci-robot k8s-ci-robot requested review from dims and richardcase May 26, 2023 09:29
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 26, 2023
@cpanato
Copy link
Member Author

cpanato commented May 26, 2023

/test ls

@k8s-ci-robot
Copy link
Contributor

@cpanato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-gcp-build
  • /test pull-cluster-api-provider-gcp-e2e-test
  • /test pull-cluster-api-provider-gcp-make
  • /test pull-cluster-api-provider-gcp-test
  • /test pull-cluster-api-provider-gcp-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-gcp-apidiff
  • /test pull-cluster-api-provider-gcp-capi-e2e
  • /test pull-cluster-api-provider-gcp-conformance
  • /test pull-cluster-api-provider-gcp-conformance-ci-artifacts
  • /test pull-cluster-api-provider-gcp-coverage
  • /test pull-cluster-api-provider-gcp-coverage-release-1-3
  • /test pull-cluster-api-provider-gcp-e2e-workload-upgrade

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-gcp-apidiff
  • pull-cluster-api-provider-gcp-build
  • pull-cluster-api-provider-gcp-e2e-test
  • pull-cluster-api-provider-gcp-make
  • pull-cluster-api-provider-gcp-test
  • pull-cluster-api-provider-gcp-verify

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato
Copy link
Member Author

cpanato commented May 26, 2023

/test pull-cluster-api-provider-gcp-conformance

@cpanato
Copy link
Member Author

cpanato commented May 26, 2023

ready
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2023
richardcase
richardcase reviewed Jun 1, 2023
View reviewed changes
Copy link
Member

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2023
@cpanato
Copy link
Member Author

cpanato commented Jun 1, 2023

/test pull-cluster-api-provider-gcp-e2e-test

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2023
@richardcase
Copy link
Member

/test pull-cluster-api-provider-gcp-e2e-test

@cpanato
Copy link
Member Author

cpanato commented Jun 5, 2023

@richardcase i will check what is going on here

cpanato added 3 commits June 6, 2023 10:32
@cpanato
bump capg images
8f801be 
Signed-off-by: cpanato <[email protected]>
@cpanato
bump k8s dependencies
8c5b80f 
Signed-off-by: cpanato <[email protected]>
@cpanato
update go in dockerfile
5d01a48 
Signed-off-by: cpanato <[email protected]>
@cpanato
Copy link
Member Author

cpanato commented Jun 6, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2023
@cpanato
Copy link
Member Author

cpanato commented Jun 6, 2023

/test pull-cluster-api-provider-gcp-e2e-workload-upgrade

@cpanato
Copy link
Member Author

cpanato commented Jun 6, 2023

/test pull-cluster-api-provider-gcp-e2e-workload-upgrade
/test pull-cluster-api-provider-gcp-conformance

@cpanato
Copy link
Member Author

cpanato commented Jun 6, 2023

@richardcase the image 1.25.10 looks like have some issue that is not working correctly, i will debug a bit more but to unblock that I set it to use the 1.25.7 that was the one before we built.

lets move this forward

@cpanato
Copy link
Member Author

cpanato commented Jun 6, 2023

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2023
@cpanato cpanato requested a review from richardcase June 6, 2023 16:00
@richardcase
Copy link
Member

the image 1.25.10 looks like have some issue that is not working correctly, i will debug a bit more but to unblock that I set it to use the 1.25.7 that was the one before we built.

@cpanato - is the issue just in the e2e tests? O see that we are still using 1.25.10 in a few places. Is that ok?

@cpanato
Copy link
Member Author

cpanato commented Jun 6, 2023

the image 1.25.10 looks like have some issue that is not working correctly, i will debug a bit more but to unblock that I set it to use the 1.25.7 that was the one before we built.

@cpanato - is the issue just in the e2e tests? O see that we are still using 1.25.10 in a few places. Is that ok?

only for the machine image we built nightly, the kubectl is fine

@richardcase
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,richardcase]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 99caf49 into kubernetes-sigs:main Jun 7, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Jun 7, 2023
@cpanato cpanato deleted the update-images branch June 7, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@richardcase richardcase

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cpanato @k8s-ci-robot @richardcase