-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Machine Pool flag reference to GKE enabling docs #880
Add Machine Pool flag reference to GKE enabling docs #880
Conversation
Prior to this change, a user would get an error when trying to provision a quickstart GKE cluster with the provided instructions. The error would instruct the user to enable the Machine Pool feature flag. This change updates the readme for enabling capg with the GKE and Machine Pool feature flags and enables users to provision quickstart GKE clusters.
|
Welcome @bubbaksmith! |
Hi @bubbaksmith. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@bubbaksmith - were you able to sort out the CLA? |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
can you sign the CLA?
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bubbaksmith The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hey everyone. I am waiting on my employer to create the Linux Foundation Organization. |
@bubbaksmith - any update on the CLA? |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Prior to this change, a user would get an error when trying to provision a quickstart GKE cluster with the current instructions. The error given from capg would instruct the user to enable the Machine Pool feature flag.
This change updates the readme for enabling capg with the GKE and Machine Pool feature flags and enables users to provision quickstart GKE clusters.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #879
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: