Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dependencies): update to capi v1.4.0 #870

Closed
wants to merge 3 commits into from
Closed

chore(dependencies): update to capi v1.4.0 #870

wants to merge 3 commits into from

Conversation

richardcase
Copy link
Member

@richardcase richardcase commented Mar 23, 2023 •
edited
Loading

What type of PR is this?

/kind other

What this PR does / why we need it:

This change updates CAPG to use CAPI v1.4.0-rc.1 to see if there are any issues with it.

Additionally changes have been made for Ginkgo v2.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Update to CAPI v1.4.0

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 23, 2023
@k8s-ci-robot
Copy link
Contributor

@richardcase: The label(s) kind/other cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind other

What this PR does / why we need it:

This change updates CAPG to use CAPI v1.4.0-rc.1 to see if there are any issues with it.

Additionally changes have been made for Ginkgo v2.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Update to CAPI v1.4.0-rc.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from cpanato and dims March 23, 2023 15:49
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 23, 2023
@richardcase
Copy link
Member Author

This is for testing only at this stage, so:

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 23, 2023
@richardcase richardcase changed the title chore(dependencies): update to capi v1.4.0-rc.1 chore(dependencies): update to capi v1.4.0 Mar 29, 2023
@richardcase
chore(dependencies): update to capi v1.4.0-rc.1
1e55de7 
This change updates CAPG to use CAPI v1.4.0-rc.1 to see if there are any
issues with it.

Additionally changes have been made for Ginkgo v2.

Signed-off-by: Richard Case <[email protected]>
@richardcase
chore(dependencies): bunp capi to v1.4.0
175dc7b 
Dump CAPI to to v1.4.0 from the rc.1 after release

Signed-off-by: Richard Case <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2023
@k8s-ci-robot
Copy link
Contributor

@richardcase: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-gcp-apidiff 0b0acba link false /test pull-cluster-api-provider-gcp-apidiff
pull-cluster-api-provider-gcp-e2e-test 0b0acba link true /test pull-cluster-api-provider-gcp-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 4, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damdo
Copy link
Member

damdo commented Jun 7, 2023

Hey @richardcase, I noticed that #945 is ready, how far would we be to land this one too?
Thanks

@cpanato
Copy link
Member

cpanato commented Jun 7, 2023

i think after this, we can do an initial release for 1.4.x serie

@damdo
Copy link
Member

damdo commented Jun 7, 2023

Awesome! Thanks

@richardcase
Copy link
Member Author

And then we can upgrade to CAPI 1.4.3

@damdo
Copy link
Member

damdo commented Jun 19, 2023

Do we need much more work to get this ready or is it just a matter of rebasing and re-running the tests?

@richardcase
Copy link
Member Author

I will update the dependencies to 1.4.3 and rebase and then we should be good to go.

@richardcase
Copy link
Member Author

Closing in favour of #968 which bumps CAPI to v1.4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato Awaiting requested review from cpanato

@dims dims Awaiting requested review from dims

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richardcase @k8s-ci-robot @damdo @cpanato