Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor cloud services into Reconcile/Delete pattern #394

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Refactor cloud services into Reconcile/Delete pattern #394

merged 1 commit into from
Jun 30, 2021

Conversation

prksu
Copy link
Contributor

@prksu prksu commented Jun 24, 2021

What type of PR is this?

This PR consists of cloud package refactors:

  • Refactor cloud services into Reconcile/Delete pattern
  • Move google compute api spec under scope package
  • Adopt github.com/GoogleCloudPlatform/k8s-cloud-provider that has a better interface. (which also used by k/cloud-provider-gcp and k/ingress-gce project)

/kind cleanup

What this PR does / why we need it:
The main purpose of this PR is to bring a consistent interface for modifying both capg (GCPCluster/GCPMachine) object and google cloud resources which inspired by capz kubernetes-sigs/cluster-api-provider-azure#110

Special notes for your reviewer:
In general, there are no API changes in this PR and have the same logic as the current behavior.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 24, 2021
@k8s-ci-robot k8s-ci-robot requested review from dims and rsmitty June 24, 2021 16:17
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 24, 2021
@prksu prksu force-pushed the refactor-cloud branch 2 times, most recently from 71a5488 to 07035ce Compare June 24, 2021 16:20
@cpanato
Copy link
Member

cpanato commented Jun 30, 2021

/test ls

@k8s-ci-robot
Copy link
Contributor

@cpanato: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cluster-api-provider-gcp-test
  • /test pull-cluster-api-provider-gcp-build
  • /test pull-cluster-api-provider-gcp-make
  • /test pull-cluster-api-provider-gcp-e2e-test
  • /test pull-cluster-api-provider-gcp-make-conformance
  • /test pull-cluster-api-provider-gcp-capi-e2e

Use /test all to run the following jobs:

  • pull-cluster-api-provider-gcp-test
  • pull-cluster-api-provider-gcp-build
  • pull-cluster-api-provider-gcp-make
  • pull-cluster-api-provider-gcp-e2e-test

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato
Copy link
Member

cpanato commented Jun 30, 2021

/test pull-cluster-api-provider-gcp-make-conformance
/test pull-cluster-api-provider-gcp-capi-e2e

cpanato
cpanato approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for taking too long

thanks for this improvement!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2021
@cpanato
Copy link
Member

cpanato commented Jun 30, 2021

/hold till the conformance finish

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2021
@cpanato
Copy link
Member

cpanato commented Jun 30, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit e9f742d into kubernetes-sigs:main Jun 30, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Jun 30, 2021
@prksu prksu deleted the refactor-cloud branch June 30, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@dims dims Awaiting requested review from dims

@rsmitty rsmitty Awaiting requested review from rsmitty

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@prksu @cpanato @k8s-ci-robot