-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for identity service server and updating identity service #1385
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: afarbos The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @afarbos. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I ran locally: |
97b4416
to
6bda6de
Compare
/ok-to-test |
Thanks @afarbos. Could you please rebase your commits to squash them into logical changes? This helps maintain a clean history and simplifies reverts, if needed. |
6bda6de
to
3cbacd9
Compare
sounds good, done! 3 commits:
|
3cbacd9
to
60fdfc2
Compare
} else if updateErr := s.updateCAPIKubeconfigSecret(ctx, configSecret); updateErr != nil { | ||
return fmt.Errorf("updating kubeconfig secret: %w", err) | ||
} else if kubeConfig, err = s.updateCAPIKubeconfigSecret(ctx, configSecret); err != nil { | ||
return nil, fmt.Errorf("updating kubeconfig secret: %w", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: this also fix the error it should have been updateErr
, now everything is err
What type of PR is this?
/kind feature
What this PR does / why we need it:
Following #1366, the goal of this PR is to expose the server used by identity enabling easier authentication without prior cluster access or secret manipulation and update of the identity service config.
Doc: https://cloud.google.com/kubernetes-engine/docs/how-to/oidc
example:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: