-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
template: add Flatcar template #1378
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tormath1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fd2e726
to
f803561
Compare
/test pull-cluster-api-provider-gcp-e2e-test |
docs/book/src/topics/flatcar.md
Outdated
@@ -0,0 +1,27 @@ | |||
# Use Flatcar images | |||
|
|||
[Flatcar](https://flatcar.org) is a Linux based OS designed to run containers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make this new section available in the book, it needs to also be added to the list of topics in ./docs/book/src/SUMMARY.md
here, maybe as a new sub-section under Self-managed clusters
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect. Thanks a lot, it makes more sense to have it here indeed.
Signed-off-by: Mathieu Tortuyaux <[email protected]>
Signed-off-by: Mathieu Tortuyaux <[email protected]>
Signed-off-by: Mathieu Tortuyaux <[email protected]>
f803561
to
9c83f61
Compare
/test pull-cluster-api-provider-gcp-e2e-test |
@tormath1: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind feature
What this PR does / why we need it: In this PR, we add Flatcar templates and documentation for folks interested to use Cluster API with Flatcar without using pre-built images.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): #1325Special notes for your reviewer: This has been tested with Kubernetes 1.30 (as 1.31 is failing currently due to the missing external CCM)
TODOs:
Release note: