Adding e2e tests for shared vpc installs #1255

barbacbd · 2024-06-04T18:35:18Z

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR is opened to add e2e tests for the feature shared vpcs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Updates ##1189

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

adds e2e tests

Release note:

Add e2e tests for the new feature of shared vpcs.

k8s-ci-robot · 2024-06-04T18:35:27Z

Hi @barbacbd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

netlify · 2024-06-04T18:35:33Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name	Link
🔨 Latest commit	`3c5e5b0`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/66620f5cd21a7c000858c3af
😎 Deploy Preview	https://deploy-preview-1255--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

scripts/ci-e2e.sh

barbacbd · 2024-06-06T14:25:11Z

/hold

barbacbd · 2024-06-06T19:37:07Z

scripts/ci-e2e.sh

+           | bash) || true
+      gcloud compute networks delete --project="${GCP_PROJECT}" \
+        --quiet "${GCP_NETWORK_NAME}" || true
+    fi


The GCP_SERVICE_PROJECT is where a lot of these resources such as image will be created during a shared vpc install. Trying to think of a way to incorporate that here on cleanup.

barbacbd · 2024-06-06T19:38:11Z

scripts/ci-e2e.sh

@@ -102,6 +102,9 @@ EOF

 # initialize a router and cloud NAT
 init_networks() {
+#  gcloud compute shared-vpc enable "$GCP_PROJECT"


These actions require more permissions. We either need to allow this permission, setup a specific project just for this e2e test, or use the same project (which wont be a shared vpc install). Any ideas @damdo ?

Not sure what's best here. @cpanato did this ever come up in the past?

if need another project to run together, i would suggest to we talk with sig-testing/sig-infra to see if that is possible when running the prow job

cpanato

/ok-to-test

k8s-triage-robot · 2024-09-11T13:42:31Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-10-11T14:26:22Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2024-11-10T14:28:59Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2024-11-10T14:29:05Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

damdo · 2024-11-10T15:24:51Z

/reopen

It'd be still be nice to see this merged.

k8s-ci-robot · 2024-11-10T15:24:56Z

@damdo: Reopened this PR.

In response to this:

/reopen

It'd be still be nice to see this merged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2024-11-10T15:25:02Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: barbacbd
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-triage-robot · 2024-12-10T16:07:01Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2024-12-10T16:07:07Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

damdo · 2024-12-10T16:54:32Z

/reopen

It'd be still be nice to see this merged.

k8s-ci-robot · 2024-12-10T16:54:38Z

@damdo: Reopened this PR.

In response to this:

/reopen

It'd be still be nice to see this merged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

damdo · 2024-12-10T16:54:45Z

Any movement on this one @barbacbd

k8s-ci-robot · 2024-12-10T17:25:13Z

@barbacbd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-gcp-e2e-test	`3c5e5b0`	link	true	`/test pull-cluster-api-provider-gcp-e2e-test`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

cpanato · 2024-12-11T09:34:45Z

/reopen

It'd be still be nice to see this merged.

agree will be nice

barbacbd · 2024-12-13T20:09:51Z

@cpanato @damdo I haven't had a chance to look into this in a while but I would need access to multiple projects to test this. The tests currently only allow for a single project. Is there a way to gain access for testing ?

k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 4, 2024

k8s-ci-robot requested review from cpanato and dims June 4, 2024 18:35

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 4, 2024

barbacbd mentioned this pull request Jun 4, 2024

Add support for Shared VPC Networking #1189

Merged

3 tasks

barbacbd force-pushed the add-shared-vpc-e2e-tests branch from 671dca4 to d221164 Compare June 4, 2024 18:58

damdo reviewed Jun 5, 2024

View reviewed changes

scripts/ci-e2e.sh Outdated Show resolved Hide resolved

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2024

Adding e2e tests for shared vpc installs

3c5e5b0

barbacbd force-pushed the add-shared-vpc-e2e-tests branch from d221164 to 3c5e5b0 Compare June 6, 2024 19:34

barbacbd commented Jun 6, 2024

View reviewed changes

barbacbd requested a review from damdo June 6, 2024 19:41

cpanato reviewed Jun 13, 2024

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 13, 2024

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 11, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 11, 2024

k8s-ci-robot closed this Nov 10, 2024

k8s-ci-robot reopened this Nov 10, 2024

k8s-ci-robot closed this Dec 10, 2024

k8s-ci-robot reopened this Dec 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding e2e tests for shared vpc installs #1255

Adding e2e tests for shared vpc installs #1255

barbacbd commented Jun 4, 2024 •

edited

Loading

k8s-ci-robot commented Jun 4, 2024

netlify bot commented Jun 4, 2024 •

edited

Loading

barbacbd commented Jun 6, 2024

barbacbd Jun 6, 2024 •

edited

Loading

barbacbd Jun 6, 2024

damdo Jun 12, 2024

cpanato Jun 13, 2024

cpanato left a comment

k8s-triage-robot commented Sep 11, 2024

k8s-triage-robot commented Oct 11, 2024

k8s-triage-robot commented Nov 10, 2024

k8s-ci-robot commented Nov 10, 2024

damdo commented Nov 10, 2024

k8s-ci-robot commented Nov 10, 2024

k8s-ci-robot commented Nov 10, 2024

k8s-triage-robot commented Dec 10, 2024

k8s-ci-robot commented Dec 10, 2024

damdo commented Dec 10, 2024

k8s-ci-robot commented Dec 10, 2024

damdo commented Dec 10, 2024

k8s-ci-robot commented Dec 10, 2024

cpanato commented Dec 11, 2024

barbacbd commented Dec 13, 2024

Adding e2e tests for shared vpc installs #1255

Are you sure you want to change the base?

Adding e2e tests for shared vpc installs #1255

Conversation

barbacbd commented Jun 4, 2024 • edited Loading

k8s-ci-robot commented Jun 4, 2024

netlify bot commented Jun 4, 2024 • edited Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

barbacbd commented Jun 6, 2024

barbacbd Jun 6, 2024 • edited Loading

Choose a reason for hiding this comment

barbacbd Jun 6, 2024

Choose a reason for hiding this comment

damdo Jun 12, 2024

Choose a reason for hiding this comment

cpanato Jun 13, 2024

Choose a reason for hiding this comment

cpanato left a comment

Choose a reason for hiding this comment

k8s-triage-robot commented Sep 11, 2024

k8s-triage-robot commented Oct 11, 2024

k8s-triage-robot commented Nov 10, 2024

k8s-ci-robot commented Nov 10, 2024

damdo commented Nov 10, 2024

k8s-ci-robot commented Nov 10, 2024

k8s-ci-robot commented Nov 10, 2024

k8s-triage-robot commented Dec 10, 2024

k8s-ci-robot commented Dec 10, 2024

damdo commented Dec 10, 2024

k8s-ci-robot commented Dec 10, 2024

damdo commented Dec 10, 2024

k8s-ci-robot commented Dec 10, 2024

cpanato commented Dec 11, 2024

barbacbd commented Dec 13, 2024

barbacbd commented Jun 4, 2024 •

edited

Loading

netlify bot commented Jun 4, 2024 •

edited

Loading

barbacbd Jun 6, 2024 •

edited

Loading