Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: basic netlify configuration for book #1131

Merged

Conversation

salasberryfin
Copy link
Contributor

@salasberryfin salasberryfin commented Feb 6, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

This PR adds the basic netlify configuration (plus minimal make tools for building the book) so that we can request a netlify site and a project subdomain.

Together with this PR, I'm opening the necessary requests in the https://github.com/kubernetes/k8s.io/ repository.

Then, when the site is up and running, I'll create a separate PR to add the base structure/contents of the book, so that we can later iterate over this and add new/improve existing topics.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

This the initial PR on an effort to sort the CAPG docs into a book #490.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Add Netlify configuration for book

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 6, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @salasberryfin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 6, 2024
@richardcase
Copy link
Member

/ok-to-tesr

@salasberryfin
Copy link
Contributor Author

@richardcase I think there's a typo in the to-test label and prow didn't start the checks

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 6, 2024
@salasberryfin salasberryfin force-pushed the netlify-config-for-book branch from d6578e3 to dabda52 Compare February 6, 2024 15:13
@salasberryfin
Copy link
Contributor Author

Fixed tests and it is now ready to be reviewed.

@salasberryfin salasberryfin requested a review from cpanato February 6, 2024 15:51
netlify.toml Outdated Show resolved Hide resolved
hack/tools/go.mod Outdated Show resolved Hide resolved
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

thanks for working on this

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, salasberryfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit 273a0d9 into kubernetes-sigs:main Feb 10, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants