Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

configure gcloud for docker #102

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Conversation

chuckha
Copy link
Contributor

@chuckha chuckha commented Jul 23, 2019

Signed-off-by: Chuck Ha [email protected]

What this PR does / why we need it:
Need to configure docker to use gcloud login as auth credentials.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #67

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 23, 2019
@k8s-ci-robot k8s-ci-robot requested review from detiber and justinsb July 23, 2019 22:46
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 23, 2019
@chuckha
Copy link
Contributor Author

chuckha commented Jul 23, 2019

/assign @ashish-amarnath

@amy
Copy link
Contributor

amy commented Jul 23, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7bebd31 into kubernetes-retired:master Jul 23, 2019
@chuckha chuckha deleted the release branch August 16, 2019 02:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants