Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

Fix up fmt.Printlns everywhere #22

Closed
chuckha opened this issue Jun 25, 2019 · 6 comments
Closed

Fix up fmt.Printlns everywhere #22

chuckha opened this issue Jun 25, 2019 · 6 comments
Assignees
@amy
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.

Comments

@chuckha
Copy link
Contributor

chuckha commented Jun 25, 2019

There are a lot of fmt.Printlns. They should be treated as a logging dependency, as in, for now it's ok to add a parameter to the function that is a logger interface. We have been using logr.Logger in a few places, so I think it would be good to continue using that.

/kind enhancement
@chuckha chuckha added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Jun 25, 2019
@chuckha
Copy link
Contributor Author

chuckha commented Jun 25, 2019

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 25, 2019
@chuckha
Copy link
Contributor Author

chuckha commented Jun 25, 2019

/remove-kind feature
/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Jun 25, 2019
@amy
Copy link
Contributor

amy commented Jun 25, 2019

/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jun 25, 2019
@amy
Copy link
Contributor

amy commented Jun 25, 2019

There are 2 main sections that have fmt.Print that can be separated out. One is within the actuators. The other portion is within /kind related files.

@amy amy mentioned this issue Jun 25, 2019
Merged
@chuckha
Copy link
Contributor Author

chuckha commented Jul 3, 2019

I think this is fine too close. there is still some work to do but will be handled by other issues

/close

@k8s-ci-robot
Copy link
Contributor

@chuckha: Closing this issue.

In response to this:

I think this is fine too close. there is still some work to do but will be handled by other issues

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@amy amy mentioned this issue Jul 3, 2019
Closed
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@amy amy

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chuckha @amy @k8s-ci-robot