Allow customization of client-go throttling #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows customization of the client-side throttling in client-go and sets a higher initial default. It is necessary for bigger setups with many domachines. The approach and naming of the flags are taken 1:1 from cluster API to keep things consistent.
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
timoreimann
reviewed
Oct 2, 2023
timoreimann
reviewed
Oct 2, 2023
main.go
Outdated
| @@ -95,6 +97,8 @@ func initFlags(fs *pflag.FlagSet) { | |||
| fs.DurationVar(&syncPeriod, "sync-period", 10*time.Minute, "The minimum interval at which watched resources are reconciled (e.g. 10m)") | |||
| fs.IntVar(&webhookPort, "webhook-port", 9443, "Webhook Server port, disabled by default. When enabled, the manager will only work as webhook server, no reconcilers are installed.") | |||
| fs.DurationVar(&reconcileTimeout, "reconcile-timeout", reconciler.DefaultLoopTimeout, "The maximum duration a reconcile loop can run (e.g. 90m)") | |||
| fs.Float32Var(&restConfigQPS, "kube-api-qps", 20, "Maximum queries per second from the controller client to the Kubernetes API server. Defaults to 20") | |||
| fs.IntVar(&restConfigBurst, "kube-api-burst", 30, "Maximum number of queries that should be allowed in one burst from the controller client to the Kubernetes API server. Default 30") | |||
There was a problem hiding this comment.
Do we need to specify the default value, or does pflag show it automatically already?
FWIW, I don't see defaults explicitly mentioned much elsewhere.
There was a problem hiding this comment.
You're right, the flags package add that anyway. Removed it.
This is already done automatically by the flags package.
timoreimann
approved these changes
Oct 5, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gottwald, timoreimann The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This allows customization of the client-side throttling in client-go and sets a higher initial default.
It is necessary for bigger setups with many domachines.
The approach and naming of the flags are taken 1:1 from cluster API to keep things consistent.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Release note:
/assign @timoreimann @cpanato