Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow updating the control plane endpoint if previously set #335

Merged
merged 1 commit into from
Jul 26, 2022
Merged

allow updating the control plane endpoint if previously set #335

merged 1 commit into from
Jul 26, 2022

Conversation

varshavaradarajan
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #334

Special notes for your reviewer:

Documentation:

Release note:

Allow updates to control plane endpoint

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 23, 2022
@k8s-ci-robot
Copy link

Hi @varshavaradarajan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 23, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 23, 2022
@cpanato
Copy link
Member

cpanato commented May 2, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 2, 2022
@MorrisLaw
Copy link
Member

/retest

@varshavaradarajan varshavaradarajan force-pushed the varsha/remove-webhook-validation branch from 8a00aa6 to 9b5516d Compare May 3, 2022 16:23
MorrisLaw
MorrisLaw reviewed May 4, 2022
View reviewed changes
Copy link
Member

@MorrisLaw MorrisLaw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try running gofmt -w on the file? File is not `goimports`-ed (goimports) seems like it could be fixed by that.

@cpanato
Copy link
Member

cpanato commented May 5, 2022

@varshavaradarajan any updates on this?

@varshavaradarajan
Copy link
Contributor Author

@cpanato - I did run gofmt but it doesn't change anything. I'll look into this more over the weekend.

@timoreimann
Copy link
Contributor

We might need to run goimports on this, not just gofmt?

@cpanato cpanato requested a review from MorrisLaw July 26, 2022 14:03
@cpanato
Copy link
Member

cpanato commented Jul 26, 2022

/assign @timoreimann @MorrisLaw

MorrisLaw
MorrisLaw approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@MorrisLaw MorrisLaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

@MorrisLaw
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2022
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MorrisLaw, varshavaradarajan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0507d7d into kubernetes-sigs:main Jul 26, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Jul 26, 2022
@varshavaradarajan varshavaradarajan deleted the varsha/remove-webhook-validation branch July 26, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisLaw MorrisLaw MorrisLaw approved these changes

@prksu prksu Awaiting requested review from prksu

Assignees

@timoreimann timoreimann

@MorrisLaw MorrisLaw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Allow updates to controlPlaneEndpoint
5 participants
@varshavaradarajan @k8s-ci-robot @cpanato @MorrisLaw @timoreimann