Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version implementation and output when starting the manager #283

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Nov 21, 2021

What this PR does / why we need it:

noticed that we don't expose a version for the manager, this PR add the version and output that when the manager start

/assign @prksu @timoreimann @MorrisLaw
/kind feature

will cherry pick that to the release-1.0 branch when merged

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Documentation:

Release note:

add version implementation and output when starting the manager

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 21, 2021
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 21, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 21, 2021
@cpanato
Copy link
Member Author

cpanato commented Nov 21, 2021

will output

I1121 16:18:53.443713   23652 logr.go:249] setup "msg"="starting manager"  "extended_info"={"major":"1","minor":"0","gitVersion":"v1.0.0-2-0914b868ffafc9-dirty","gitCommit":"0914b868ffafc91517acf159d603996dbb53f47c","gitTreeState":"dirty","buildDate":"2021-11-21T15:18:42Z","goVersion":"go1.17.3","compiler":"gc","platform":"darwin/amd64"} "version"="v1.0.0-2-0914b868ffafc9-dirty"

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, prksu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@prksu
Copy link
Contributor

prksu commented Nov 30, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit 81229f4 into kubernetes-sigs:main Nov 30, 2021
@cpanato cpanato deleted the version branch December 1, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants