-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update klog dependency to v2 #243
Conversation
Welcome @stmcginnis! |
Hi @stmcginnis. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign Hi @stmcginnis thanks for taking this work, I'm holding this PR for now until we have prepared for capi |
This switches klog usage over to klog v2.5.0 to match the current version being used in k/k. This should also address some issues we're seeing that have since been fixed in klog between the quite old v1.0.0 and v2.5.0 Signed-off-by: Sean McGinnis <[email protected]>
Rebased to address conflicts on master. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold cancel
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: prksu, stmcginnis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
The klog v1 dependency used is quite old now, and the k/k repo has
switched to more recent v2 versions for quite some time now.
This updates klog usage to use the v2 package version.
Special notes for your reviewer:
This is part of an overall effort along with updating the k-sigs/cluster-api repo here:
kubernetes-sigs/cluster-api#4284
Release note: