💎 cloud: Refactor Subnets scope to interface

cloud/interfaces.go

@@ -67,6 +67,7 @@ type ClusterDescriber interface {
 	Location() string
 	AdditionalTags() infrav1.Tags
 	Vnet() *infrav1.VnetSpec
+	IsVnetManaged() bool
 	NodeSubnet() *infrav1.SubnetSpec
 	ControlPlaneSubnet() *infrav1.SubnetSpec
 	RouteTable() *infrav1.RouteTable

cloud/scope/cluster.go

@@ -153,11 +153,39 @@ func (s *ClusterScope) RouteTableSpecs() []azure.RouteTableSpec {
 	}}
 }
 
+// SubnetSpecs returns the subnets specs.
+func (s *ClusterScope) SubnetSpecs() []azure.SubnetSpec {
+	return []azure.SubnetSpec{
+		{
+			Name:                s.ControlPlaneSubnet().Name,
+			CIDR:                s.ControlPlaneSubnet().CidrBlock,
+			VNetName:            s.Vnet().Name,
+			SecurityGroupName:   s.ControlPlaneSubnet().SecurityGroup.Name,
+			Role:                s.ControlPlaneSubnet().Role,
+			RouteTableName:      s.ControlPlaneSubnet().RouteTable.Name,
+			InternalLBIPAddress: s.ControlPlaneSubnet().InternalLBIPAddress,
+		},
+		{
+			Name:              s.NodeSubnet().Name,
+			CIDR:              s.NodeSubnet().CidrBlock,
+			VNetName:          s.Vnet().Name,
+			SecurityGroupName: s.NodeSubnet().SecurityGroup.Name,
+			RouteTableName:    s.NodeSubnet().RouteTable.Name,
+			Role:              s.NodeSubnet().Role,
+		},
+	}
+}
+
 // Vnet returns the cluster Vnet.
 func (s *ClusterScope) Vnet() *infrav1.VnetSpec {
 	return &s.AzureCluster.Spec.NetworkSpec.Vnet
 }
 
+// IsVnetManaged returns true if the vnet is managed.
+func (s *ClusterScope) IsVnetManaged() bool {
+	return s.Vnet().ID == "" || s.Vnet().Tags.HasOwned(s.ClusterName())
+}
+
 // Subnets returns the cluster subnets.
 func (s *ClusterScope) Subnets() infrav1.Subnets {
 	return s.AzureCluster.Spec.NetworkSpec.Subnets

cloud/scope/machine.go

@@ -151,6 +151,7 @@ func (m *MachineScope) DiskSpecs() []azure.DiskSpec {
 	spec := azure.DiskSpec{
 		Name: azure.GenerateOSDiskName(m.Name()),
 	}
+
 	return []azure.DiskSpec{spec}
 }
 

cloud/services/subnets/mock_subnets/doc.go

@@ -15,6 +15,8 @@ limitations under the License.
 */
 
 // Run go generate to regenerate this mock.
-//go:generate ../../../../hack/tools/bin/mockgen -destination subnets_mock.go -package mock_subnets -source ../client.go Client
+//go:generate ../../../../hack/tools/bin/mockgen -destination client_mock.go -package mock_subnets -source ../client.go Client
+//go:generate ../../../../hack/tools/bin/mockgen -destination subnets_mock.go -package mock_subnets -source ../service.go SubnetScope
+//go:generate /usr/bin/env bash -c "cat ../../../../hack/boilerplate/boilerplate.generatego.txt client_mock.go > _client_mock.go && mv _client_mock.go client_mock.go"
 //go:generate /usr/bin/env bash -c "cat ../../../../hack/boilerplate/boilerplate.generatego.txt subnets_mock.go > _subnets_mock.go && mv _subnets_mock.go subnets_mock.go"
 package mock_subnets //nolint