Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏃 remove unused ci script and rename templates #634

Merged
merged 1 commit into from
May 20, 2020
Merged

🏃 remove unused ci script and rename templates #634

merged 1 commit into from
May 20, 2020

Conversation

chewong
Copy link
Member

@chewong chewong commented May 20, 2020 •
edited
Loading

What this PR does / why we need it:

Follow-up PR for #617. This PR also moved export KUBECONFIG="${KUBECONFIG:-${PWD}/kubeconfig}" out of run_upstream_e2e_tests so external E2E test cases are being run against the workload cluster instead of the management cluster.

/test pull-cluster-api-provider-azure-conformance-v1alpha3-master
/test pull-cluster-api-provider-azure-conformance-v1alpha3-1-18
/assign @CecileRobertMichon

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 20, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels May 20, 2020
CecileRobertMichon
CecileRobertMichon reviewed May 20, 2020
View reviewed changes
templates/test/prow/patches/tags.yaml
jobName: ${JOB_NAME}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chewong
Copy link
Member Author

chewong commented May 20, 2020

/test pull-cluster-api-provider-azure-conformance-v1alpha3-master
/test pull-cluster-api-provider-azure-conformance-v1alpha3-1-18

CecileRobertMichon
CecileRobertMichon approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold

@chewong please squash the commits

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, chewong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2020
@chewong
Copy link
Member Author

chewong commented May 20, 2020

/approve
/hold

@chewong please squash the commits

PTAL.

@chewong
Copy link
Member Author

chewong commented May 20, 2020

/test pull-cluster-api-provider-azure-conformance-v1alpha3-master
/test pull-cluster-api-provider-azure-conformance-v1alpha3-1-18

@CecileRobertMichon
Copy link
Contributor

/lgtm

Feel free to cancel the hold once the conformance jobs pass and you're ready to merge.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2020
@chewong
Copy link
Member Author

chewong commented May 20, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit fc0a458 into kubernetes-sigs:master May 20, 2020
@k8s-ci-robot k8s-ci-robot added this to the v0.5 milestone May 20, 2020
@chewong chewong deleted the patch-ci-entrypoint branch May 20, 2020 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon approved these changes

@devigned devigned Awaiting requested review from devigned

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4.x
Development

Successfully merging this pull request may close these issues.
3 participants
@chewong @k8s-ci-robot @CecileRobertMichon