Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏃Update several dependencies #587

Merged
merged 1 commit into from
May 1, 2020

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented May 1, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

- Update Azure/azure-sdk-for-go dependency to v42.0.0
- Update golang/mock dependency to v1.4.3
- Update pelletier/go-toml dependency to v1.7.0
- Update spf13/viper dependency to v1.6.3
- Update Azure/go-autorest dependency to v14.0.1
- Update golangci/golangci-lint dependency to v1.25.1
- Update google/go-cmp dependency to v0.4.0
- Update gophercloud/gophercloud dependency to v0.10.0
- Update hashicorp/golang-lru dependency to v0.5.4
- Update kubernetes/code-generator dependency to v0.18.2
- Update Azure/go-autorest/autorest/adal dependency to v0.8.3

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 1, 2020
@k8s-ci-robot k8s-ci-robot requested review from devigned and serbrech May 1, 2020 12:24
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels May 1, 2020
@devigned
Copy link
Contributor

devigned commented May 1, 2020

Updating project dependencies should be an episode of "Dirty Jobs". Thank you!

@devigned
Copy link
Contributor

devigned commented May 1, 2020

Error: go [-e -json -compiled=true -test=false -export=false -deps=true -find=false -tags ignore_autogenerated -- ./api/... ./exp/api/...]: exit status 1: go: github.com/blang/[email protected]+incompatible: reading https://proxy.golang.org/github.com/blang/semver/@v/v3.6.1+incompatible.mod: 410 Gone

That's kind of odd...

@cpanato
Copy link
Member Author

cpanato commented May 1, 2020

trying to check what is wrong @devigned no clue now

@cpanato cpanato marked this pull request as draft May 1, 2020 12:32
@cpanato
Copy link
Member Author

cpanato commented May 1, 2020

so looks like there is an issue: golang/go#31944 (comment)

will remove that from the update for now

@cpanato cpanato changed the title Update several dependencies 🏃Update several dependencies May 1, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 1, 2020
- Update `Azure/azure-sdk-for-go` dependency to
[v42.0.0](https://github.com/Azure/azure-sdk-for-go/tree/v42.0.0) which
is the latest available and has the [following
changes](https://github.com/Azure/azure-sdk-for-go/releases/tag/v42.0.0)
- Update `golang/mock` dependency to
[v1.4.3](https://github.com/golang/mock/tree/v1.4.3) which is the latest
available and has the [following
changes](https://github.com/golang/mock/releases/tag/v1.4.3)
- Update `pelletier/go-toml` dependency to
[v1.7.0](https://github.com/pelletier/go-toml/tree/v1.7.0) which is the
latest available and has the [following
changes](https://github.com/pelletier/go-toml/releases/tag/v1.7.0)
- Update `spf13/viper` dependency to
[v1.6.3](https://github.com/spf13/viper/tree/v1.6.3) which is the latest
available and has the [following
changes](https://github.com/spf13/viper/releases/tag/v1.6.3)
- Update `Azure/go-autorest` dependency to
[v14.0.1](https://github.com/Azure/go-autorest/tree/v14.0.1) which is
the latest available and has the [following
changes](https://github.com/Azure/go-autorest/releases/tag/v14.0.1)
- Update `golangci/golangci-lint` dependency to
[v1.25.1](https://github.com/golangci/golangci-lint/tree/v1.25.1) which
is the latest available and has the [following
changes](https://github.com/golangci/golangci-lint/releases/tag/v1.25.1)
- Update `google/go-cmp` dependency to
[v0.4.0](https://github.com/google/go-cmp/tree/v0.4.0) which is the
latest available and has the [following
changes](https://github.com/google/go-cmp/releases/tag/v0.4.0)
- Update `gophercloud/gophercloud` dependency to
[v0.10.0](https://github.com/gophercloud/gophercloud/tree/v0.10.0) which
is the latest available and has the [following
changes](https://github.com/gophercloud/gophercloud/releases/tag/v0.10.0)
- Update `hashicorp/golang-lru` dependency to
[v0.5.4](https://github.com/hashicorp/golang-lru/tree/v0.5.4) which is
the latest available and has the [following
changes](https://github.com/hashicorp/golang-lru/releases/tag/v0.5.4)
- Update `kubernetes/code-generator` dependency to
[v0.18.2](https://github.com/kubernetes/code-generator/tree/v0.18.2)
which is the latest available and has the [following
changes](https://github.com/kubernetes/code-generator/releases/tag/v0.18.2)
- Update `Azure/go-autorest/autorest/adal` dependency to
[v0.8.3](https://github.com/Azure/go-autorest/tree/autorest/adal/v0.8.3)
which is the latest available and has the [following
changes](https://github.com/Azure/go-autorest/releases/tag/autorest%2Fadal%2Fv0.8.3)
@cpanato cpanato marked this pull request as ready for review May 1, 2020 13:02
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 1, 2020
@CecileRobertMichon
Copy link
Contributor

@cpanato can you please list all the dependencies updated in the release note?

/hold
/approve

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2020
@cpanato
Copy link
Member Author

cpanato commented May 1, 2020

done @CecileRobertMichon

@CecileRobertMichon
Copy link
Contributor

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 1, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit fcbf48e into kubernetes-sigs:master May 1, 2020
@k8s-ci-robot k8s-ci-robot added this to the v0.5 milestone May 1, 2020
@cpanato cpanato deleted the update-deps branch May 1, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants